Fix failed lro cases #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After confirmed with Deya this failure is caused by Azure/azure-sdk-for-js#24159. We couldn't remove the poll() call. So I close this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original pr is Azure#1586 and it has below ci failures:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=2034536&view=logs&j=71cc2e7d-6454-5bf0-71b5-f1eef07a6c23&t=f2857310-5d68-5640-1409-0ba88dcfe076&l=1299
I fixed this failures by removing the
poll()call, https://github.com/joheredi/autorest.typescript/pull/2/files#diff-30776bf0dca3d9ed8226f91676dbb870808482bad53e453d798160add8cca23e.Because I notice it would introduce one more http request which is not expected when we are in sync way to handle LRO request. But I am not sure this is correct or not when we call
createHttpPoller.@deyaaeldeen Could you help explain the differences between
poller.poll(),poller.pollUntilDoneand review this change?After this fix the ci passed: Azure#1689.
/cc @qiaozha