[core-amqp] Handle case of ErrorEvent being passed as Error to rhea #29297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rhea expects an Error object https://github.com/amqp/rhea/blob/2.0.8/lib/connection.js#L591 but some times it gets an ErrorEvent instead from certain packages, ws for example https://github.com/websockets/ws/blob/8.16.0/lib/event-target.js#L224 while rhea may be changed to unwrap the error from an ErrorEvent instance, this PR handles the ErrorEvent case in our code base since we have more control here.
deyaaeldeen
reviewed
Apr 15, 2024
sdk/core/core-amqp/src/errors.ts
Outdated
Comment on lines
638
to
642
| let result: boolean = false; | ||
| if (typeof err.error === "object" && typeof err.message === "string") { | ||
| result = true; | ||
| } | ||
| return result; |
There was a problem hiding this comment.
nitpick: couldn't it be simplified as follows?
Suggested change
| let result: boolean = false; | |
| if (typeof err.error === "object" && typeof err.message === "string") { | |
| result = true; | |
| } | |
| return result; | |
| return typeof err.error === "object" && typeof err.message === "string"; |
deyaaeldeen
approved these changes
Apr 15, 2024
|
API change check API changes are not detected in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rhea expects an Error object
https://github.com/amqp/rhea/blob/2.0.8/lib/connection.js#L591 but some times it
gets an ErrorEvent instead from certain packages, ws for example
https://github.com/websockets/ws/blob/8.16.0/lib/event-target.js#L224
while rhea may be changed to unwrap the error from an ErrorEvent instance, this PR handles the ErrorEvent case in our code base since we have more control here.
Packages impacted by this PR
@azure/core-amqpIssues associated with this PR
#29294