-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/js signoff pipeline #29442
Fix/js signoff pipeline #29442
Conversation
…ure-sdk-for-js into fix/js-signoff-pipeline
API change check API changes are not detected in this pull request. |
@@ -51,7 +51,7 @@ function encodeNumberAsUInt64JSBI(value: number): JSBI { | |||
const rawValueBits = getRawBitsJSBI(value); | |||
const mask = JSBI.BigInt(0x8000000000000000); | |||
const returned = | |||
rawValueBits < mask | |||
JSBI.toNumber(rawValueBits) < JSBI.toNumber(mask) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might lose precision here. is it ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will correct this. we can use JSBI.greaterThan() instead.
@aditishree1 Please add details about these changes in the PR "Describe the problem that is addressed by this PR" section. |
Packages impacted by this PR
@azure/cosmos
Issues associated with this PR
Describe the problem that is addressed by this PR
This PR fixes the failed tests by mainly addressing following issues:
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists