Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing slash from namedExports #4617

Merged
merged 1 commit into from Aug 1, 2019
Merged

Remove trailing slash from namedExports #4617

merged 1 commit into from Aug 1, 2019

Conversation

mikeharder
Copy link
Member

@mikeharder
Remove trailing slash from namedExports
2956422 
- Was required due to rollup/rollup-plugin-commonjs#394
- Fixed in rollup-plugin-commonjs@1.10.1
daviwil
daviwil approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@daviwil daviwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nice to get rid of this!

@mikeharder
Copy link
Member Author

mikeharder commented Aug 1, 2019 •
edited

@daviwil: This was actually fixed in rollup-plugin-commonjs about a month ago, but I didn't realize until today. To be clear, this is unrelated to resolve@1.12.0 (#4613).

@mikeharder mikeharder merged commit 91f5f7f into Azure:master Aug 1, 2019
@mikeharder mikeharder deleted the remove-trailing-slash-named-exports branch August 1, 2019 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviwil daviwil daviwil approved these changes

@HarshaNalluru HarshaNalluru HarshaNalluru approved these changes

@bterlson bterlson Awaiting requested review from bterlson

@chradek chradek Awaiting requested review from chradek

@jeremymeng jeremymeng Awaiting requested review from jeremymeng

@sophiajt sophiajt Awaiting requested review from sophiajt

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

@sadasant sadasant Awaiting requested review from sadasant

@ShivangiReja ShivangiReja Awaiting requested review from ShivangiReja

@vinjiang vinjiang Awaiting requested review from vinjiang

@XiaoningLiu XiaoningLiu Awaiting requested review from XiaoningLiu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mikeharder @daviwil @HarshaNalluru