Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing slash from namedExports #4617

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 2 additions & 5 deletions sdk/core/abort-controller/rollup.base.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,9 @@ export function browserConfig(test = false) {
preferBuiltins: false
}),
cjs({
// When "rollup-plugin-commonjs@10.0.0" is used with "resolve@1.11.1", named exports of
// modules with built-in names must have a trailing slash.
// https://github.com/rollup/rollup-plugin-commonjs/issues/394
namedExports: {
"events/": ["EventEmitter"],
"assert/": ["ok", "deepEqual", "equal", "fail", "deepStrictEqual", "notDeepEqual"]
events: ["EventEmitter"],
assert: ["ok", "deepEqual", "equal", "fail", "deepStrictEqual", "notDeepEqual"]
}
})
]
Expand Down
5 changes: 1 addition & 4 deletions sdk/core/core-amqp/rollup.base.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,9 @@ export function browserConfig(test = false) {
}),

cjs({
// When "rollup-plugin-commonjs@10.0.0" is used with "resolve@1.11.1", named exports of
// modules with built-in names must have a trailing slash.
// https://github.com/rollup/rollup-plugin-commonjs/issues/394
namedExports: {
chai: ["should"],
"assert/": ["equal", "deepEqual", "notEqual"]
assert: ["equal", "deepEqual", "notEqual"]
}
}),

Expand Down
5 changes: 1 addition & 4 deletions sdk/eventhub/event-hubs/rollup.base.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,8 @@ export function browserConfig(test = false) {
}),

cjs({
// When "rollup-plugin-commonjs@10.0.0" is used with "resolve@1.11.1", named exports of
// modules with built-in names must have a trailing slash.
// https://github.com/rollup/rollup-plugin-commonjs/issues/394
namedExports: {
"events/": ["EventEmitter"]
events: ["EventEmitter"]
}
}),

Expand Down
5 changes: 1 addition & 4 deletions sdk/eventhub/event-processor-host/rollup.base.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,7 @@ export function browserConfig(test = false) {
preferBuiltins: false
}),
cjs({
// When "rollup-plugin-commonjs@10.0.0" is used with "resolve@1.11.1", named exports of
// modules with built-in names must have a trailing slash.
// https://github.com/rollup/rollup-plugin-commonjs/issues/394
namedExports: { "events/": ["EventEmitter"] }
namedExports: { events: ["EventEmitter"] }
}),
json()
]
Expand Down
5 changes: 1 addition & 4 deletions sdk/identity/identity/rollup.base.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,7 @@ export function browserConfig(test = false, production = false) {
preferBuiltins: false
}),
cjs({
// When "rollup-plugin-commonjs@10.0.0" is used with "resolve@1.11.1", named exports of
// modules with built-in names must have a trailing slash.
// https://github.com/rollup/rollup-plugin-commonjs/issues/394
namedExports: { "events/": ["EventEmitter"] }
namedExports: { events: ["EventEmitter"] }
}),
viz({ filename: "browser/browser-stats.html", sourcemap: false })
]
Expand Down
5 changes: 1 addition & 4 deletions sdk/keyvault/keyvault-keys/rollup.base.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,7 @@ export function browserConfig(test = false) {
}),
cjs({
namedExports: {
// When "rollup-plugin-commonjs@10.0.0" is used with "resolve@1.11.1", named exports of
// modules with built-in names must have a trailing slash.
// https://github.com/rollup/rollup-plugin-commonjs/issues/394
"assert/": ["ok", "equal", "strictEqual"]
assert: ["ok", "equal", "strictEqual"]
}
})
]
Expand Down
5 changes: 1 addition & 4 deletions sdk/keyvault/keyvault-secrets/rollup.base.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,7 @@ export function browserConfig(test = false) {
}),
cjs({
namedExports: {
// When "rollup-plugin-commonjs@10.0.0" is used with "resolve@1.11.1", named exports of
// modules with built-in names must have a trailing slash.
// https://github.com/rollup/rollup-plugin-commonjs/issues/394
"assert/": ["ok", "equal", "strictEqual"]
assert: ["ok", "equal", "strictEqual"]
}
})
]
Expand Down
5 changes: 1 addition & 4 deletions sdk/servicebus/service-bus/rollup.base.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,7 @@ export function browserConfig({ test = false, production = false } = {}) {
dedupe: ["buffer"]
}),
cjs({
// When "rollup-plugin-commonjs@10.0.0" is used with "resolve@1.11.1", named exports of
// modules with built-in names must have a trailing slash.
// https://github.com/rollup/rollup-plugin-commonjs/issues/394
namedExports: { "events/": ["EventEmitter"], long: ["ZERO"] }
namedExports: { events: ["EventEmitter"], long: ["ZERO"] }
}),

// rhea and rhea-promise use the Buffer global which requires
Expand Down
7 changes: 2 additions & 5 deletions sdk/storage/storage-blob/rollup.base.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,9 @@ export function browserConfig(test = false, production = false) {
preferBuiltins: false
}),
cjs({
// When "rollup-plugin-commonjs@10.0.0" is used with "resolve@1.11.1", named exports of
// modules with built-in names must have a trailing slash.
// https://github.com/rollup/rollup-plugin-commonjs/issues/394
namedExports: {
"events/": ["EventEmitter"],
"assert/": ["ok", "deepEqual", "equal", "fail", "deepStrictEqual", "notDeepEqual"]
events: ["EventEmitter"],
assert: ["ok", "deepEqual", "equal", "fail", "deepStrictEqual", "notDeepEqual"]
}
})
]
Expand Down
7 changes: 2 additions & 5 deletions sdk/storage/storage-file/rollup.base.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,9 @@ export function browserConfig(test = false, production = false) {
preferBuiltins: false
}),
cjs({
// When "rollup-plugin-commonjs@10.0.0" is used with "resolve@1.11.1", named exports of
// modules with built-in names must have a trailing slash.
// https://github.com/rollup/rollup-plugin-commonjs/issues/394
namedExports: {
"events/": ["EventEmitter"],
"assert/": [
events: ["EventEmitter"],
assert: [
"ok",
"deepEqual",
"equal",
Expand Down
5 changes: 1 addition & 4 deletions sdk/storage/storage-queue/rollup.base.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,7 @@ export function browserConfig(test = false, production = false) {
}),
cjs({
namedExports: {
// When "rollup-plugin-commonjs@10.0.0" is used with "resolve@1.11.1", named exports of
// modules with built-in names must have a trailing slash.
// https://github.com/rollup/rollup-plugin-commonjs/issues/394
"assert/": ["ok", "deepEqual", "equal", "fail", "deepStrictEqual"]
assert: ["ok", "deepEqual", "equal", "fail", "deepStrictEqual"]
}
})
]
Expand Down
5 changes: 1 addition & 4 deletions sdk/template/template/rollup.base.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,7 @@ export function browserConfig(test = false, production = false) {
preferBuiltins: false
}),
cjs({
// When "rollup-plugin-commonjs@10.0.0" is used with "resolve@1.11.1", named exports of
// modules with built-in names must have a trailing slash.
// https://github.com/rollup/rollup-plugin-commonjs/issues/394
namedExports: { "events/": ["EventEmitter"] }
namedExports: { events: ["EventEmitter"] }
}),
viz({ filename: "browser/browser-stats.html", sourcemap: false })
]
Expand Down