Skip to content

Commit

Permalink
Sync eng/common directory with azure-sdk-tools repository (#43766)
Browse files Browse the repository at this point in the history
  • Loading branch information
azure-sdk committed Apr 29, 2024
1 parent f3f1c6a commit 2d022c7
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
7 changes: 6 additions & 1 deletion eng/common/scripts/Create-APIReview.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,12 @@ function Submit-APIReview($packageInfo, $packagePath, $packageArtifactName)

function IsApiviewStatusCheckRequired($packageInfo)
{
if (($packageInfo.SdkType -eq "client" -or $packageInfo.SdkType -eq "spring") -and $packageInfo.IsNewSdk) {
if ($IsApiviewStatusCheckRequiredFn -and (Test-Path "Function:$IsApiviewStatusCheckRequiredFn"))
{
return &$IsApiviewStatusCheckRequiredFn $packageInfo
}

if ($packageInfo.SdkType -eq "client" -and $packageInfo.IsNewSdk) {
return $true
}
return $false
Expand Down
1 change: 1 addition & 0 deletions eng/common/scripts/common.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ $GetEmitterAdditionalOptionsFn = "Get-${Language}-EmitterAdditionalOptions"
$GetEmitterNameFn = "Get-${Language}-EmitterName"
$GetDirectoriesForGenerationFn = "Get-${Language}-DirectoriesForGeneration"
$UpdateGeneratedSdksFn = "Update-${Language}-GeneratedSdks"
$IsApiviewStatusCheckRequiredFn = "Get-${Language}-ApiviewStatusCheckRequirement"

# Expected to be set in eng/scripts/docs/Docs-Onboarding.ps1
$SetDocsPackageOnboarding = "Set-${Language}-DocsPackageOnboarding"
Expand Down

0 comments on commit 2d022c7

Please sign in to comment.