Skip to content

Commit

Permalink
Add ApiCompat to GA library sln files (#9626)
Browse files Browse the repository at this point in the history 
* Add ApiCompat to Storage soln

* Update contributing.md

* Update soln for other GA libraries
  • Loading branch information
@JoshLove-msft
JoshLove-msft committed Jan 25, 2020
1 parent b53a871 commit af976ca
Show file tree
Hide file tree
Showing 8 changed files with 90 additions and 44 deletions.
1 change: 1 addition & 0 deletions CONTRIBUTING.md
View file
Expand Up @@ -132,6 +132,7 @@ The `ApiCompatVerification` target defined in `ApiCompat.csproj` is referenced i

### Adding a new GA'ed library
To include add a new GA'ed library in the `ApiCompatVerification` target, add a package reference for the library to the `ApiCompat.csproj` file. You will also need to include the latest GA version of the library in [eng/Packages.Data.props](https://github.com/Azure/azure-sdk-for-net/blob/master/eng/Packages.Data.props).
Finally, include the `ApiCompat.csproj` in your solution so that the project will get automatically restored in Visual Studio.

### Releasing a new version of a GA'ed libary
Since the [eng/Packages.Data.props](https://github.com/Azure/azure-sdk-for-net/blob/master/eng/Packages.Data.props) is currently maintained manually, you will need to update the version number for your library in this file when releasing a new version.
Expand Down
2 changes: 1 addition & 1 deletion eng/ApiCompat/ApiCompat.csproj
View file
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk" DefaultTargets="ApiCompatVerification">
<Project Sdk="Microsoft.NET.Sdk">
<!--This project is used to enforce API compatibility between the GA'ed libraries and the most recent version available on Nuget. The most recent
version is restored from Nuget via the package references below. The ApiCompatVerification target, specified below, is referenced in the
eng/Directory.Build.Data.targets file which causes this target to be executed for each csproj that has the EnableApiCompat parameter set to true.
Expand Down
1 change: 1 addition & 0 deletions eng/Directory.Build.Data.targets
View file
Expand Up @@ -125,6 +125,7 @@
<MSBuild
Projects="$(MSBuildThisFileDirectory)/ApiCompat/ApiCompat.csproj"
Properties="TargetPackageName=$(PackageId);TargetOutputPath=$(IntermediateOutputPath)"
Targets="ApiCompatVerification"
/>
</Target>

Expand Down
6 changes: 6 additions & 0 deletions sdk/appconfiguration/Azure.Data.AppConfiguration/Azure.Data.AppConfiguration.sln
View file
Expand Up @@ -13,6 +13,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Azure.Data.AppConfiguration
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Azure.Identity", "..\..\identity\Azure.Identity\src\Azure.Identity.csproj", "{042736B0-D082-4366-BD2B-02D49FEC6073}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ApiCompat", "..\..\..\eng\ApiCompat\ApiCompat.csproj", "{CB965318-37F5-4FD9-ACE4-08634BAC833D}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand All @@ -39,6 +41,10 @@ Global
{042736B0-D082-4366-BD2B-02D49FEC6073}.Debug|Any CPU.Build.0 = Debug|Any CPU
{042736B0-D082-4366-BD2B-02D49FEC6073}.Release|Any CPU.ActiveCfg = Release|Any CPU
{042736B0-D082-4366-BD2B-02D49FEC6073}.Release|Any CPU.Build.0 = Release|Any CPU
{CB965318-37F5-4FD9-ACE4-08634BAC833D}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{CB965318-37F5-4FD9-ACE4-08634BAC833D}.Debug|Any CPU.Build.0 = Debug|Any CPU
{CB965318-37F5-4FD9-ACE4-08634BAC833D}.Release|Any CPU.ActiveCfg = Release|Any CPU
{CB965318-37F5-4FD9-ACE4-08634BAC833D}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down
106 changes: 63 additions & 43 deletions sdk/core/Azure.Core/Azure.Core.All.sln
View file

Large diffs are not rendered by default.

6 changes: 6 additions & 0 deletions sdk/identity/Azure.Identity/Azure.Identity.sln
View file
Expand Up @@ -15,6 +15,8 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
README.md = README.md
EndProjectSection
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ApiCompat", "..\..\..\eng\ApiCompat\ApiCompat.csproj", "{FF91A707-7A2D-4D6D-A785-B75CBBB7B2C9}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand All @@ -33,6 +35,10 @@ Global
{CD0BE1AA-F99E-48E7-9FFD-F1B288E62B4F}.Debug|Any CPU.Build.0 = Debug|Any CPU
{CD0BE1AA-F99E-48E7-9FFD-F1B288E62B4F}.Release|Any CPU.ActiveCfg = Release|Any CPU
{CD0BE1AA-F99E-48E7-9FFD-F1B288E62B4F}.Release|Any CPU.Build.0 = Release|Any CPU
{FF91A707-7A2D-4D6D-A785-B75CBBB7B2C9}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{FF91A707-7A2D-4D6D-A785-B75CBBB7B2C9}.Debug|Any CPU.Build.0 = Debug|Any CPU
{FF91A707-7A2D-4D6D-A785-B75CBBB7B2C9}.Release|Any CPU.ActiveCfg = Release|Any CPU
{FF91A707-7A2D-4D6D-A785-B75CBBB7B2C9}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down
6 changes: 6 additions & 0 deletions sdk/keyvault/Azure.Security.KeyVault.sln
View file
Expand Up @@ -25,6 +25,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Azure.Identity.Tests", "..\
EndProject
Project("{D954291E-2A0B-460D-934E-DC6B0785DB48}") = "Azure.Security.KeyVault.Shared.Tests", "Azure.Security.KeyVault.Shared\tests\Azure.Security.KeyVault.Shared.Tests.shproj", "{1AFA2644-A1D9-419F-B87D-9B519B673F24}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ApiCompat", "..\..\eng\ApiCompat\ApiCompat.csproj", "{A0C00A76-5F21-4664-A7B1-BE2DA201BF6E}"
EndProject
Global
GlobalSection(SharedMSBuildProjectFiles) = preSolution
Azure.Security.KeyVault.Shared\src\Azure.Security.KeyVault.Shared.projitems*{1198491f-d3cd-4d23-b536-e89d65b9d965}*SharedItemsImports = 13
Expand Down Expand Up @@ -71,6 +73,10 @@ Global
{A9EE98A1-2769-4D37-A336-8418184A4448}.Debug|Any CPU.Build.0 = Debug|Any CPU
{A9EE98A1-2769-4D37-A336-8418184A4448}.Release|Any CPU.ActiveCfg = Release|Any CPU
{A9EE98A1-2769-4D37-A336-8418184A4448}.Release|Any CPU.Build.0 = Release|Any CPU
{A0C00A76-5F21-4664-A7B1-BE2DA201BF6E}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{A0C00A76-5F21-4664-A7B1-BE2DA201BF6E}.Debug|Any CPU.Build.0 = Debug|Any CPU
{A0C00A76-5F21-4664-A7B1-BE2DA201BF6E}.Release|Any CPU.ActiveCfg = Release|Any CPU
{A0C00A76-5F21-4664-A7B1-BE2DA201BF6E}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down
6 changes: 6 additions & 0 deletions sdk/storage/Azure.Storage.sln
View file
Expand Up @@ -111,6 +111,8 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Batch", "Batch", "{610DBA57
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Azure.Storage.Blobs.Batch.Tests", "Azure.Storage.Blobs.Batch\tests\Azure.Storage.Blobs.Batch.Tests.csproj", "{2C48AA18-94E2-4B8E-9345-DCA941B13EB1}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ApiCompat", "..\..\eng\ApiCompat\ApiCompat.csproj", "{16260507-C87E-44D2-883F-8E338B7A519F}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -197,6 +199,10 @@ Global
{2C48AA18-94E2-4B8E-9345-DCA941B13EB1}.Debug|Any CPU.Build.0 = Debug|Any CPU
{2C48AA18-94E2-4B8E-9345-DCA941B13EB1}.Release|Any CPU.ActiveCfg = Release|Any CPU
{2C48AA18-94E2-4B8E-9345-DCA941B13EB1}.Release|Any CPU.Build.0 = Release|Any CPU
{16260507-C87E-44D2-883F-8E338B7A519F}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{16260507-C87E-44D2-883F-8E338B7A519F}.Debug|Any CPU.Build.0 = Debug|Any CPU
{16260507-C87E-44D2-883F-8E338B7A519F}.Release|Any CPU.ActiveCfg = Release|Any CPU
{16260507-C87E-44D2-883F-8E338B7A519F}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down

0 comments on commit af976ca

Please sign in to comment.