Add NativeBlobSoftDeleteDeletionDetectionPolicy to Microsoft.Azure.Search library

[xantari]

Library or service name.

Microsoft.Auzre.Search

Is your feature request related to a problem? Please describe.

It appears that since the 09/2019 release you have had a public preview of "NativeBlobSoftDeleteDeletionDetectionPolicy" delete policy.

However the Microsoft.Azure.Search does not have an ability to define that deletion policy.

Information about Native blob soft delete is here: https://docs.microsoft.com/en-us/azure/search/search-howto-indexing-azure-blob-storage

[AlexGhiondea]

/cc @tg-msft for our Track 2 library.

@xantari we have started work on a new version of the Search library -- we are going to consider including this for our upcoming library.

[tg-msft]

/cc @heaths as this would be on our data source APIs

[heaths]

Thanks for bringing this to my attention. The new packages do support it, but perhaps not in a very intuitive way. @brjohnstmsft, right now these are exposed as models that just need to exist in the JSON payload. I suggest we make them boolean properties like Data(Change|Deletion)DetectionPolicyEnabled. Perhaps we could drop "Policy" to shorten it, but I do like the symmetry with the documentation, such that searching for "DataDeletionDetectionPolicy", for example, yields a match.

[heaths]

Sorry, I see those classes should actually be abstract (see #9686) and I see that swagger does not actually define @odata.type "#Microsoft.Azure.Search.NativeBlobSoftDeleteDeletionDetectionPolicy". We can define one manually, but this should be in the Preview swagger as well if it's still supported.

[brjohnstmsft]

@heaths I defer to @bleroy or @arv100kri for API design opinions in this area.

[heaths]

Blocked on Azure/azure-rest-api-specs#9160. This could be done without but requires taking over de/serialization completely instead of using generated code, which continues to evolve. At least, we can wait until time no longer allows for getting a change to swagger.

[heaths]

@bleroy, @arv100kri do you have any timeframe for defining this type in swagger?

Sorry, I see those classes should actually be abstract (see #9686) and I see that swagger does not actually define @odata.type "#Microsoft.Azure.Search.NativeBlobSoftDeleteDeletionDetectionPolicy". We can define one manually, but this should be in the Preview swagger as well if it's still supported.

[ghost]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @felixwa, @brjohnstmsft.

[heaths]

Blocked on the service team, so punting to preview 5 since this is only additive.

[heaths]

It doesn't look like this is going to make it, so punting.

[brjohnstmsft]

@heaths In cases like this where SDK changes are blocked on Swagger changes, I recommend putting the "Service Attention" tag only on the Swagger issue in azure-rest-api-specs. Otherwise, ownership isn't clear and our issue SLA metrics are affected. I've removed the tag since it's already present on the corresponding azure-rest-api-specs issue.

[heaths]

This is tracking Azure/azure-rest-api-specs#9160 which is both in that repo and has the "Service Attention" tag. This is to complete our work once done.

[jennifermarsman]

This has been merged into Track 2 SDK. PR: Azure/azure-rest-api-specs#10308 @heaths can this issue be closed?

[heaths]

Yes. Thanks for the reminder. Support for this will be in the Azure.Search.Documents package.

[david-brink-talogy]

@heaths , did this get included in Azure.Search.Documents? I see no use of the phrase NativeBlobSoftDeleteDeletionDetectionPolicy anywhere in https://github.com/Azure/azure-sdk-for-net.

Shouldn't it be here with SoftDeleteColumnDeletionDetectionPolicy:
https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/search/Azure.Search.Documents/src/Generated/Models

[Mohit-Chakraborty]

@jennifermarsman, @jadrefke - the update to the REST spec was reverted a few weeks after it was added and it has been like that since.

Are there plans to add it back?

[Mohit-Chakraborty]

We don't have immediate plans to expose this functionality via the SDK. Will update this issue once we add it.
Closing the issue for now.

cc: @gmndrg, @dereklegenzoff

[xantari]

Is there a separate issue I should monitor to keep an eye on this since this issue was closed?

[gmndrg]

Hello, this issue has been closed since we will reopen when our team is actively working on it. Right now the efforts for this are on hold with no ETA. You can keep following up this thread since we will definitely get back to it when we can allocate the resources to keep working on this accordingly. You can write anytime here and we'll get back to you gladly with any update available. This is a preview feature. It will have full support when/if going into GA based on https://azure.microsoft.com/en-us/support/legal/preview-supplemental-terms/. Apologies since we are not able to provide more info at this time. Thank you for understanding. From: xantari ***@***.***> Sent: Wednesday, December 8, 2021 4:46 PM To: Azure/azure-sdk-for-net ***@***.***> Cc: Gia Mondragon ***@***.***>; Mention ***@***.***> Subject: Re: [Azure/azure-sdk-for-net] Add NativeBlobSoftDeleteDeletionDetectionPolicy to Microsoft.Azure.Search library (#11435) Is there a separate issue I should monitor to keep an eye on this since this issue was closed? - You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-net%2Fissues%2F11435%23issuecomment-989288384&data=04%7C01%7CGiannina.Mondragon%40microsoft.com%7C4149c7e079fb4fec279408d9ba9c8cf2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637746003820675149%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=bHFXvujmHI9njVaUI40imwbFiAw%2F8EYhUl0G4xZ7q%2FM%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALBWI72FTY6IGR2RN7ZVKV3UP7N3VANCNFSM4ML6BI2A&data=04%7C01%7CGiannina.Mondragon%40microsoft.com%7C4149c7e079fb4fec279408d9ba9c8cf2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637746003820675149%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=LFVn3B4WrMlEDwufTafIQFZO%2B7kLluo0wUTiCz%2BLNu0%3D&reserved=0>. Triage notifications on the go with GitHub Mobile for iOS<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7CGiannina.Mondragon%40microsoft.com%7C4149c7e079fb4fec279408d9ba9c8cf2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637746003820675149%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=WhW9YV0q78mfK6vqxbNUXse4jMVBTn1%2BoUwNSXykA9U%3D&reserved=0> or Android<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7CGiannina.Mondragon%40microsoft.com%7C4149c7e079fb4fec279408d9ba9c8cf2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637746003820675149%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=76ApuwlRgRFfqnAr%2FObesiz%2FT7a5pj3jopvgwta6mk4%3D&reserved=0>.

[a2741890]

Is the Azure.Search.Document still being updated? The last beta version released was in November 2021.

[gmndrg]

Hello @a2741890, yes, please check https://www.nuget.org/packages/Azure.Search.Documents/#versions-body-tab You can see the latest beta versions and the latest was out 4 days ago.

The original thread is already closed. For new threads, please submit a new issue. Thank you.