Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve architect feedback on CLU #36514

Closed
3 tasks done
heaths opened this issue May 25, 2023 · 2 comments · Fixed by #36637
Closed
3 tasks done

Resolve architect feedback on CLU #36514

heaths opened this issue May 25, 2023 · 2 comments · Fixed by #36637
Assignees
@heaths
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Language late-blocker Changes based on review feedback before imminent release.
Milestone
2023-06

Comments

@heaths
Copy link
Member

heaths commented May 25, 2023 •
edited
Loading

  • Make async endpoint AnalyzeConversation (LRO) plural i.e., AnalyzeConversations.
  • Hide (make internal) ConversationsAudience until architect re-review discussion has completed. We shouldn't need this for the 1.1.0 GA.
  • Remove the word "Job" from CancelAnalyzeConversationJob and friends.
@heaths heaths added Client This issue points to a problem in the data-plane of the library. blocking-release Blocks release Cognitive - Language late-blocker Changes based on review feedback before imminent release. labels May 25, 2023
@heaths heaths added this to the 2023-06 milestone May 25, 2023
@heaths heaths self-assigned this May 25, 2023
@heaths
Copy link
Member Author

heaths commented May 25, 2023

@kristapratico @johanste would you want to make your analyze_conversation LRO plural (add an "s") as well for consistency?

@kristapratico
Copy link
Member

We have a different method for the async endpoint (begin_conversation_analysis). I think it makes sense for Python to keep analzye_conversation singular since it's not overloaded and only targets the sync endpoint / one conversation.

@heaths heaths mentioned this issue May 30, 2023
Merged
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue May 30, 2023
@heaths
Resolve architect feedback
17ba7c3 
Resolves Azure#36514
heaths added a commit that referenced this issue May 31, 2023
@heaths
Resolve architect feedback (#36637)
9036b06 
Resolves #36514
abhinav-ghai pushed a commit that referenced this issue Jun 1, 2023
@arlynch @sjiherzig
@rateitel @vishweshbankwar @azure-sdk @JimSuplizio @sarkar-rajarshi @rajkumar-rangaraj @live1206 @dvbb @abhishesingh-msft @ArcturusZhang @annelo-msft @seanmcc-msft @jalauzon-msft @hallipr @joseharriaga @raych1 @rohithkumar91 @heaths
Update to new api version 2023-06-30 (#36161)
52f593e 
* Initial generation

* Fix double line break, add API version to rest client  options

* Generate API

* add old versions back in to fix build

* creation of new test resources and updated test recordings

* new bulk tests skeleton

* update/add test for import api

* move new test variables into service specific config file

* fixing tests and updated rest api spec commit id

* final testing changes

* serialize entire exception in the case of test failure

* initial job lifecycle sample code

* add code to upload input blob to storage container for quickstart sample

* updates to quickstart sample

* Updated code to latest api version

* Updated samples for clarity

* fixed build errors

* Add separate meterprovider for standard metrics (#36369)

* Add separate meterprovider for standard metrics

* assert cloud role name value

* remove unnecessary using

* Remove defunct template (#36543)

Co-authored-by: James Suplizio <jasupliz@microsoft.com>

* [ACS JobRouter] Protocol methods for merge-patch support to remove properties (#36513)

* protocol methods for merge-patch support to remove properties

* address review feedback

* Change foreach loop to use ref readonly for tag/event/link enumeration (#36544)

* Increment package version after release of Azure.ResourceManager.ApplicationInsights (#36541)

* Increment package version after release of Azure.ResourceManager.Analysis (#36539)

* Add ThumbprintString property to mgmt (#36320)

* Add ThumbprintString property to websites.

* Add ThumbprintString for automation.

* Update

* Add ThumbprintString for batch

* Add Thumbprint for iothub

* Add ThumbprintString for notificationhubs

* update

* update

* update

* Fix test

* Add obsolete attribute and make Thumbprint backwards compatible.

* enable model factory (#36499)

* enable model factory (#36519)

* Increment package version after release of Azure.ResourceManager.AppConfiguration (#36567)

* Increment package version after release of Azure.ResourceManager.AppPlatform (#36568)

* Increment package version after release of Azure.ResourceManager.ArcScVmm (#36569)

* Increment package version after release of Azure.ResourceManager.Attestation (#36570)

* Increment package version after release of Azure.ResourceManager.Authorization (#36571)

* Increment package version after release of Azure.ResourceManager.Cdn (#36576)

* Increment package version after release of Azure.ResourceManager.Chaos (#36577)

* Increment package version after release of Azure.ResourceManager.BotService (#36578)

* Increment package version after release of Azure.ResourceManager.BillingBenefits (#36581)

* Increment package version after release of Azure.ResourceManager.ChangeAnalysis (#36579)

* Update AutoRest C# version to 3.0.0-beta.20230528.2 (#36574)

* Update Generator Version 3.0.0-beta.20230528.2

* Update SDK codes

* Introduce model factory to mgmt SDK batch 3 (#36500)

* enable model factory

* do not need release hci

* update

* enable model factory (#36527)

* enable model factory (#36528)

* Increment package version after release of Azure.ResourceManager.Blueprint (#36590)

* Introduce model factory to mgmt SDK batch 7 (#36529)

* enable model factory

* update databox version

* enable model factory (#36531)

* enable model factory (#36559)

* enable model factory (#36560)

* enable model factory (#36561)

* enable model factory (#36562)

* enable model factory (#36566)

* enable model factory (#36573)

* enable model factory (#36575)

* enable model factory (#36580)

* enable model factory (#36582)

* Introduce model factory to mgmt SDK batch 19 (#36583)

* enable model factory (#36584)

* enable model factory (#36585)

* enable model factory (#36586)

* enable model factory (#36588)

* Increment package version after release of Azure.ResourceManager.Automation (#36592)

* Increment package version after release of Azure.ResourceManager.Confluent (#36593)

* Increment package version after release of Azure.ResourceManager.Automanage (#36594)

* Increment package version after release of Azure.ResourceManager.Billing (#36595)

* Increment package version after release of Azure.ResourceManager.Avs (#36597)

* Increment package version after release of Azure.ResourceManager.Consumption (#36598)

* Increment package version after release of Azure.ResourceManager.Communication (#36596)

* Increment package version after release of Azure.ResourceManager.ConnectedVMwarevSphere (#36600)

* Increment package version after release of Azure.ResourceManager.Batch (#36599)

* Increment package version after release of Azure.ResourceManager.CognitiveServices (#36601)

* Increment package version after release of Azure.ResourceManager.ConfidentialLedger (#36602)

* enable model factory (#36589)

* enable model factory (#36591)

* Introduce model factory to mgmt SDK batch 13 (#36563)

* Increment package version after release of Azure.ResourceManager.ContainerInstance (#36604)

* Increment package version after release of Azure.ResourceManager.Datadog (#36605)

* Increment package version after release of Azure.ResourceManager.DataBoxEdge (#36606)

* Increment package version after release of Azure.ResourceManager.AppContainers (#36608)

* Increment package version after release of Azure.ResourceManager.ContainerRegistry (#36609)

* Increment package version after release of Azure.ResourceManager.DataLakeAnalytics (#36607)

* Increment package version after release of Azure.ResourceManager.CustomerInsights (#36610)

* Increment package version after release of Azure.ResourceManager.DataMigration (#36611)

* Increment package version after release of Azure.ResourceManager.CosmosDB (#36612)

* Abhishesingh msft/dtmf actions live tests (#36557)

* Live test for Continuous Dtmf Detection and Send Dtmf scenario

* Live test for Start Continuous Dtmf Recognition

* enable model factory (#36603)

* Fix deserialization for empty ResourceIdentifier (#36613)

* Introduce tags related test cases (#36232)

* update resourcemanager

* introduce test cases, but not fully working

* introduce a fix

* record all the new test cases

* bump version (#36617)

* handle null status code (#36547)

* Return CLR null for JSON elements with JsonValueKind.Null (#36552)

* Return JsonElements with JsonValueKind.Null as CLR null

* Add tests and return null from indexer as well.

* Add cases validating exceptions are thrown

* STG 88 Release Prep (#36624)

* [Storage][DataMovement] Change test event asserts to CollectionAssert (#36553)

* Removed Batch's project reference on Core (#36631)

* Increment version for storage releases (#36629)

* Increment package version after release of Azure.Storage.Blobs.Batch (#36635)

* Use test registry in npmrc for alpha packages (#36628)

Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>

* [Text Analytics] Rename ExtractSummary and AbstractSummary (#36555)

* Enable model factory for PolicyInsights (#36618)

* Increment package version after release of Azure.ResourceManager.Grafana (#36667)

* Increment package version after release of Azure.ResourceManager.Kusto (#36691)

* Increment package version after release of Azure.ResourceManager.HybridContainerService (#36692)

* Increment package version after release of Azure.ResourceManager.ManagedServices (#36690)

* Increment package version after release of Azure.ResourceManager.NetworkFunction (#36693)

* Increment package version after release of Azure.ResourceManager.LabServices (#36689)

* Increment package version after release of Azure.ResourceManager.GuestConfiguration (#36663)

* Increment package version after release of Azure.ResourceManager.ExtendedLocations (#36664)

* Increment package version after release of Azure.ResourceManager.HDInsight (#36665)

* Increment package version after release of Azure.ResourceManager.MixedReality (#36696)

* Increment package version after release of Azure.ResourceManager.MarketplaceOrdering (#36698)

* Increment package version after release of Azure.ResourceManager.Nginx (#36697)

* Increment package version after release of Azure.ResourceManager.NetApp (#36702)

* Increment package version after release of Azure.ResourceManager.Network (#36701)

* Increment package version after release of Azure.ResourceManager.MobileNetwork (#36700)

* Increment package version after release of Azure.ResourceManager.Media (#36699)

* Increment package version after release of Azure.ResourceManager.MySql (#36695)

* Increment package version after release of Azure.ResourceManager.NewRelicObservability (#36694)

* Increment package version after release of Azure.ResourceManager.EventGrid (#36661)

* Increment package version after release of Azure.ResourceManager.MachineLearning (#36688)

* Increment package version after release of Azure.ResourceManager.ManagedServiceIdentities (#36687)

* Increment package version after release of Azure.ResourceManager.Marketplace (#36686)

* Increment package version after release of Azure.ResourceManager.Maps (#36685)

* Increment package version after release of Azure.ResourceManager.Maintenance (#36684)

* Increment package version after release of Azure.ResourceManager.HybridCompute (#36683)

* Increment package version after release of Azure.ResourceManager.Logic (#36682)

* Increment package version after release of Azure.ResourceManager.IotHub (#36681)

* Increment package version after release of Azure.ResourceManager.HybridData (#36680)

* Increment package version after release of Azure.ResourceManager.Kubernetes (#36677)

* Increment package version after release of Azure.ResourceManager.KeyVault (#36678)

* Increment package version after release of Azure.ResourceManager.ManagementPartner (#36679)

* Increment package version after release of Azure.ResourceManager.ManagedNetwork (#36676)

* Increment package version after release of Azure.ResourceManager.MachineLearningCompute (#36675)

* Increment package version after release of Azure.ResourceManager.LoadTesting (#36674)

* Increment package version after release of Azure.ResourceManager.HybridConnectivity (#36673)

* Increment package version after release of Azure.ResourceManager.KubernetesConfiguration (#36672)

* Increment package version after release of Azure.ResourceManager.IotCentral (#36671)

* Increment package version after release of Azure.ResourceManager.HealthcareApis (#36670)

* Increment package version after release of Azure.ResourceManager.HealthBot (#36669)

* Increment package version after release of Azure.ResourceManager.FluidRelay (#36668)

* Increment package version after release of Azure.ResourceManager.FrontDoor (#36666)

* Increment package version after release of Azure.ResourceManager.ContainerService (#36643)

* Increment package version after release of Azure.ResourceManager.DataShare (#36644)

* Increment package version after release of Azure.ResourceManager.DataProtectionBackup (#36645)

* Increment package version after release of Azure.ResourceManager.DataBox (#36646)

* Increment package version after release of Azure.ResourceManager.Dns (#36647)

* Increment package version after release of Azure.ResourceManager.DataLakeStore (#36648)

* Increment package version after release of Azure.ResourceManager.DevSpaces (#36649)

* Increment package version after release of Azure.ResourceManager.DeviceUpdate (#36650)

* Increment package version after release of Azure.ResourceManager.DeploymentManager (#36651)

* Increment package version after release of Azure.ResourceManager.DnsResolver (#36652)

* Increment package version after release of Azure.ResourceManager.DeviceProvisioningServices (#36653)

* Increment package version after release of Azure.ResourceManager.Dynatrace (#36654)

* Increment package version after release of Azure.ResourceManager.DevTestLabs (#36655)

* Increment package version after release of Azure.ResourceManager.DigitalTwins (#36656)

* Increment package version after release of Azure.ResourceManager.EventHubs (#36657)

* Increment package version after release of Azure.ResourceManager.ElasticSan (#36658)

* Increment package version after release of Azure.ResourceManager.Elastic (#36659)

* Increment package version after release of Azure.ResourceManager.EdgeOrder (#36660)

* Updated changelog to describe new import job feature

* Sync eng/common directory with azure-sdk-tools for PR 6222 (#36703)

* Updated typespec common script

* Updated per the review comment

---------

Co-authored-by: raychen <raychen@microsoft.com>

* doc for sdk release (#34837)

* doc for sdl release

* sdk release

* sdk release

* updated version in SessionRecords json file

* updated version number

* version changed in json file

* updated version

* updated version

* sdk release

* sdk generation

* sdk release

* sdk release

* sdk release

* Update sampes

* Merge from main and regenerate code.

* SDK release

* sdk release

* sdk release

* doc for sdk release

* doc for sdk release

* Update

---------

Co-authored-by: Wei Hu <huwe@microsoft.com>

* Sync eng/common directory with azure-sdk-tools for PR 6250 (#36708)

* Revert the change and return tsplocation folder

* Out null for the new-item command

* exit if return failure when call sync script

* Added repo assignment in local path scenario

* Added more output

* Fix path processing in windows

* exit when run generate script with error

---------

Co-authored-by: raychen <raychen@microsoft.com>

* Enable model factory for hci (#36712)

* Resolve architect feedback (#36637)

Resolves #36514

* Calculate `timeSinceEnqueued` for consumer spans (#36625)

* calculate timesinceenqueued

* refactor

* Update sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/TraceHelper.cs

Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com>

* address pr comments

* address pr comments

* align

* Address pr comments

* spelling

---------

Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com>

* [Storage][DataMovement] Add a small delay before asserting job status events (#36636)

* Initial generation

* Fix double line break, add API version to rest client  options

* Generate API

* add old versions back in to fix build

* creation of new test resources and updated test recordings

* new bulk tests skeleton

* update/add test for import api

* move new test variables into service specific config file

* fixing tests and updated rest api spec commit id

* final testing changes

* serialize entire exception in the case of test failure

* initial job lifecycle sample code

* add code to upload input blob to storage container for quickstart sample

* updates to quickstart sample

* Updated code to latest api version

* Updated samples for clarity

* fixed build errors

* Updated changelog to describe new import job feature

* updated tests and test records

---------

Co-authored-by: Sebastian Herzig-Patel <seherzig@microsoft.com>
Co-authored-by: Rachel Teitelbaum <rateitel@microsoft.com>
Co-authored-by: Austin Lynch <austinlynch@microsoft.com>
Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: James Suplizio <jasupliz@microsoft.com>
Co-authored-by: Rajarshi Sarkar <73562869+sarkar-rajarshi@users.noreply.github.com>
Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com>
Co-authored-by: Wei Hu <live1206@gmail.com>
Co-authored-by: Chengming <61542202+dvbb@users.noreply.github.com>
Co-authored-by: abhishesingh-msft <123186776+abhishesingh-msft@users.noreply.github.com>
Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com>
Co-authored-by: Anne Thompson <annelo@microsoft.com>
Co-authored-by: Sean McCullough <44180881+seanmcc-msft@users.noreply.github.com>
Co-authored-by: Jacob Lauzon <96087589+jalauzon-msft@users.noreply.github.com>
Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
Co-authored-by: Jose Arriaga Maldonado <45773732+joseharriaga@users.noreply.github.com>
Co-authored-by: raychen <raychen@microsoft.com>
Co-authored-by: rohithkumar91 <122775727+rohithkumar91@users.noreply.github.com>
Co-authored-by: Wei Hu <huwe@microsoft.com>
Co-authored-by: Heath Stewart <heaths@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heaths heaths

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Language late-blocker Changes based on review feedback before imminent release.
Projects
Azure SDK for Cognitive Services - Language
Status: Done
Milestone
2023-06
Development

Successfully merging a pull request may close this issue.

Resolve architect feedback heaths/azure-sdk-for-net
2 participants
@heaths @kristapratico