Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CertificateClientLiveTests should reset challenge cache in record and playback modes #9356

Closed
heaths opened this issue Jan 7, 2020 · 0 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone

Comments

@heaths
Copy link
Member

heaths commented Jan 7, 2020

Other client tests for Key Vault have code like the following we should add to CertificateClientLiveTests for the reasons stated in the comment:

        [SetUp]
        public void ClearChallengeCacheforRecord()
        {
            // in record mode we reset the challenge cache before each test so that the challenge call
            // is always made.  This allows tests to be replayed independently and in any order
            if (Mode == RecordedTestMode.Record || Mode == RecordedTestMode.Playback)
            {
                Client = GetClient();

                ChallengeBasedAuthenticationPolicy.AuthenticationChallenge.ClearCache();
            }
        }
@heaths heaths added Client This issue points to a problem in the data-plane of the library. KeyVault labels Jan 7, 2020
@heaths heaths self-assigned this Feb 10, 2020
@heaths heaths added this to the [2020] March milestone Feb 10, 2020
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Feb 15, 2020
@heaths heaths closed this as completed in 4f61603 Feb 19, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

No branches or pull requests

1 participant