Limit max number of expired leases acquired #11062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
serkantkaraca
commented
Apr 6, 2020
•
serkantkaraca
commented
- Limiting max number of expired leases acquired so that one host alone won't take over all leases.
- Release lease on shutdown before attempting to close the underlying receiver.
- Move to storage client set timeouts on LeaseStoreExistsAsync and CreateLeaseStoreIfNotExistsAsync to avoid timeouts during lease store initialization.
- Adding test for skipping start of stream checkpointing
- Reducing receive timeouts to shorten test run times.
- Move EPH tests from base class to child class to avoid running same tests twice; once for base class and once for child class.
serkantkaraca
commented
Apr 6, 2020
| [Fact] | ||
| [LiveTest] | ||
| [DisplayTestMethodName] | ||
| public async Task DontCheckpointStartOfStream() |
There was a problem hiding this comment.
public async Task DontCheckpointStartOfStream() [](start = 8, length = 47)
This is the new test added in this PR, rest is move from base class to child class.
JamesBirdsall
approved these changes
Apr 6, 2020
| @@ -249,7 +253,7 @@ async Task RunAsync() | |||
| try | |||
| { | |||
| allLeases[subjectLease.PartitionId] = subjectLease; | |||
| if (subjectLease.Owner == this.host.HostName) | |||
| if (subjectLease.Owner == this.host.HostName && !(await subjectLease.IsExpired())) | |||
There was a problem hiding this comment.
Nit: ConfigureAwait? #Resolved
|
Thanks James! |
serkantkaraca
deleted the
EventProcessorHost.LimitMaxNumberOfOwnedLeases
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.