Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX - (ADF) suppress exceptions during deserialization #1338

Merged
merged 1 commit into from Aug 1, 2015
Merged

HOTFIX - (ADF) suppress exceptions during deserialization #1338

merged 1 commit into from Aug 1, 2015

Conversation

bgold09
Copy link
Member

@bgold09 bgold09 commented Aug 1, 2015

This change ensures that during JSON deserialization, any exceptions are suppressed so as not to break Get/List calls. We should assume that the service sends back valid JSON and not throw.

This fix is needed in POSH as well. I will send a PR for that once this is merged and a new nuget is pushed.

I will add logging later to ensure that we can capture stack traces, etc. for any such serialization issues.

@azurecla
Copy link

azurecla commented Aug 1, 2015

Hi @bgold09, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (brgold). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

stankovski added a commit that referenced this pull request Aug 1, 2015
HOTFIX - (ADF) suppress exceptions during deserialization
@stankovski stankovski merged commit a76ead9 into Azure:master Aug 1, 2015
@bgold09 bgold09 deleted the deserFix branch October 31, 2017 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants