Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce ActivitySource events #16371

Closed

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented Oct 28, 2020

This is a prototype of producing ActivitySource events without taking a dependency on a newer version for System.Diagnostics.DiagnosticsSource package.

TODO: test with OpenTelemetry exporter to make sure things are functioning correctly.

Depends on microsoft/ApplicationInsights-dotnet#2185

@ghost ghost added the Azure.Core label Oct 28, 2020
@pakrym
Copy link
Contributor Author

pakrym commented Oct 28, 2020

cc @reyang @cijothomas

@jsquire
Copy link
Member

jsquire commented Dec 11, 2020

Hi @pakrym. There hasn't been recent engagement on this PR. Would you please be so kind as to let us know if this is still an active work stream or if the PR should be closed out?

@jsquire jsquire added the no-recent-activity There has been no recent activity on this issue. label Dec 11, 2020
@pakrym
Copy link
Contributor Author

pakrym commented Dec 11, 2020

Hi @pakrym. There hasn't been recent engagement on this PR. Would you please be so kind as to let us know if this is still an active work stream or if the PR should be closed out?

I've pushed a commit a few days ago :) Still working on it.

@jsquire jsquire removed the no-recent-activity There has been no recent activity on this issue. label Dec 14, 2020
@jsquire
Copy link
Member

jsquire commented Jan 22, 2021

Hi @pakrym. There hasn't been recent engagement on this PR. Would you please be so kind as to let us know if this is still an active work stream by removing the no-recent-activity label? Otherwise, we'll close this out in 7 days.

@pakrym pakrym closed this Jan 22, 2021
@pakrym pakrym reopened this Jan 28, 2021
@pakrym
Copy link
Contributor Author

pakrym commented Jan 28, 2021

This needs actual E2E testing with OT.

@cijothomas
Copy link
Contributor

See also: dotnet/aspnetcore#29132

@cijothomas
Copy link
Contributor

@shirhatti FYI

…NET5 instead of forcing it on everyone by lifting the reference version.
…itySource-events

# Conflicts:
#	sdk/eventgrid/Azure.Messaging.EventGrid/src/Customization/EventGridPublisherClient.cs
#	sdk/servicebus/Azure.Messaging.ServiceBus/src/Sender/ServiceBusSender.cs
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label May 14, 2021
@ghost
Copy link

ghost commented May 14, 2021

Hi @pakrym. Thank you, for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost removed the no-recent-activity There has been no recent activity on this issue. label May 14, 2021
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

@pakrym pakrym closed this May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants