-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Produce ActivitySource events #16371
Conversation
Hi @pakrym. There hasn't been recent engagement on this PR. Would you please be so kind as to let us know if this is still an active work stream or if the PR should be closed out? |
I've pushed a commit a few days ago :) Still working on it. |
Hi @pakrym. There hasn't been recent engagement on this PR. Would you please be so kind as to let us know if this is still an active work stream by removing the |
…itySource-events # Conflicts: # sdk/core/Azure.Core.TestFramework/src/Azure.Core.TestFramework.csproj
This needs actual E2E testing with OT. |
See also: dotnet/aspnetcore#29132 |
@shirhatti FYI |
…NET5 instead of forcing it on everyone by lifting the reference version.
…itySource-events # Conflicts: # sdk/eventgrid/Azure.Messaging.EventGrid/src/Customization/EventGridPublisherClient.cs # sdk/servicebus/Azure.Messaging.ServiceBus/src/Sender/ServiceBusSender.cs
Hi @pakrym. Thank you, for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For data-plane/track 2 SDKs Issue the following command as a pull request comment:
For track 1 management-plane SDKsPlease open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification. |
This is a prototype of producing ActivitySource events without taking a dependency on a newer version for System.Diagnostics.DiagnosticsSource package.
TODO: test with OpenTelemetry exporter to make sure things are functioning correctly.
Depends on microsoft/ApplicationInsights-dotnet#2185