New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional samples #30430
Merged
Merged
Additional samples #30430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshLove-msft
commented
Aug 9, 2022
API change check API changes are not detected in this pull request. |
JoshLove-msft
commented
Aug 9, 2022
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpMessageConverter.cs
Outdated
Show resolved
Hide resolved
m-redding
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes lgtm
jsquire
approved these changes
Aug 10, 2022
sdk/servicebus/Azure.Messaging.ServiceBus/samples/Sample01_HelloWorld.md
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/samples/Sample03_SendReceiveSessions.md
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/samples/Sample13_AdvancedConfiguration.md
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/samples/Sample14_AMQPMessage.md
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/samples/Sample14_AMQPMessage.md
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/samples/Sample14_AMQPMessage.md
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/samples/Sample14_AMQPMessage.md
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpMessageConverter.cs
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/tests/Samples/Sample13_AdvancedConfiguration.cs
Show resolved
Hide resolved
/azp run net - servicebus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/check-enforcer evaluate |
/check-enforcer override |
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
* Additional samples * fix * Fix footer bug * Fix check * Fix links * Make delivery annotations check consistent with other checks * typos * PR fb * make tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #28215
Also fixes bug where Footer was not being included on received message.