resolve some issues in azure.resourcemanager.appservice #30526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArcturusZhang
requested review from
KrzysztofCwalina,
tg-msft,
m-nash,
fengzhou-msft,
archerzz,
Yao725 and
ArthurMa1978
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Comment on lines
3164
to
3165
| public virtual Azure.Response<Azure.ResourceManager.AppService.WebSiteConnectionStringConfigResource> Get(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; } | ||
| public virtual System.Threading.Tasks.Task<Azure.Response<Azure.ResourceManager.AppService.WebSiteConnectionStringConfigResource>> GetAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; } |
There was a problem hiding this comment.
It feels like this resource could be configured as nonresource as the only operation on the Resource class is to get itself.
There was a problem hiding this comment.
Yes, we have tons of this kind of configuration resources in appservice.
I will have some discussion with Elendil to decide whether we should keep these as resources or non-resources.
And BTW it shows here because I changed its name to make it more readable
|
This pull request is protected by Check Enforcer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.