Blob Storage support for ParameterBindingData reference type #31757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
This was referenced Oct 12, 2022
mathewc
reviewed
Oct 21, 2022
.../Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/Config/BlobsExtensionConfigProvider.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Oct 21, 2022
.../Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/Config/BlobsExtensionConfigProvider.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Oct 21, 2022
.../Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/Config/BlobsExtensionConfigProvider.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Oct 21, 2022
.../Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/Config/BlobsExtensionConfigProvider.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Oct 21, 2022
.../Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/Config/BlobsExtensionConfigProvider.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/Config/BlobsExtensionConfigProvider.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/build.ps1
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Jan 12, 2023
.../Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/Config/BlobsExtensionConfigProvider.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Jan 12, 2023
.../Microsoft.Azure.WebJobs.Extensions.Storage.Blobs/src/Config/BlobsExtensionConfigProvider.cs
Show resolved
Hide resolved
|
@amnguye @weshaggard Hello, we have just pushed the WebJobs SDK, and I removed the myget reference from the config file - we should be good to merge! |
liliankasem
requested review from
weshaggard
and removed request for
jsquire,
benbp,
tg-msft,
hallipr,
fabiocav,
surgupta-msft,
jaschrep-msft and
seanmcc-msft
amnguye
reviewed
Feb 2, 2023
weshaggard
dismissed
their stale review
feed has been removed so dismissing my request.
liliankasem
force-pushed
the
sdk-bindings/support-reference-type
branch
2 times, most recently
from
27af59b
to
76503e1
Compare
liliankasem
force-pushed
the
sdk-bindings/support-reference-type
branch
from
76503e1
to
60bc0fc
Compare
richardcho-msft
pushed a commit
to richardcho-msft/azure-sdk-for-net
that referenced
this pull request
Feb 6, 2023
…1757) * Add converter rules for richbindingreferencetype * add RichBindingReferenceType rules and converter * add build script * update BlobTriggerAttributeBindingProvider * update ref dictionary * update local version * Update to connection name and checking null case * Renaming to ParameterBindingData * cleanup * bind to new ParameterBindingData schema * update script * Try content as json string * use ExpandoObject * Update Constants file * Fix input binding * Use updated ParameterBindingData * Address feedback * Update usage of ParameterBindingData and cleanup * Add azure_app_service_staging and script - both to undo before merge * address feedback * Add BlobTrigger_BindingToParameterBindingData test * add input binding test * Fix tests * Validate connection name * Added input converter for ParameterBindingData * Removing unnecessary comment * Updating connection string resolution logic * Updating unused usings * Removing duplicate code * Added test for ParameterBindingData collection * Removing blank line * Removing unused constants * Fixing test * Adding storage constants * Added env variable * Updating blob trigger test * Adding environment variables * Add env variables * Add env variables in tests * Adding correct using * Fixing failing test * Fixing test * Added createContainer method * Fix build issue * Removing comment * Deleting unused build file * Removing code duplication to resolve connection * Resolving connection section * Removing configuration * Added nameResolver logic * Assigning connectionSection.Key instead of value * Updated test assert * Updated test assert * Added connection string in test * Test fix * Fixing failing tests * Fixing failing tests * Passing configuration in tests for storage setting * Fix failing tests by sending config correctly * Test comment * Updated support for array type * Updated collection support code * Adding test for array * Added test * Added string array test * reset NuGet.Config --------- Co-authored-by: Surgupta <surgupta@microsoft.com>
richardcho-msft
pushed a commit
to richardcho-msft/azure-sdk-for-net
that referenced
this pull request
Feb 6, 2023
…ture (Azure#33863) Update change log to include new feature supporting ParameterBindingData in the blob storage webjobs ext PR: Azure#31757
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Azure Functions team is working on enabling SDK-type bindings for out-of-proc language workers. To enable this, we are introducing a reference type that contains all the information the worker would require to hydrate the SDK-type on the worker side, instead of passing the payload through the host. You can read internal design document here.
This PR adds rules and converters for
ParameterBindingDatawhich is the reference type mentioned above ^Related issue: Azure/azure-functions-dotnet-worker#1081