Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] Update documentation #31867

Merged
merged 7 commits into from
Oct 20, 2022
Merged

[Identity] Update documentation #31867

merged 7 commits into from
Oct 20, 2022

Conversation

pvaneck
Copy link
Member

@pvaneck pvaneck commented Oct 18, 2022

This updates the README and TROUBLESHOOTING files for greater consistency with other language docs and for general enhancement.

Closes: #31064

This updates the README and TROUBLESHOOTING files for
greater consistency with other language docs and for general
enhancement.

Ref: Azure#31064

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

sdk/identity/Azure.Identity/README.md Outdated Show resolved Hide resolved
sdk/identity/Azure.Identity/README.md Outdated Show resolved Hide resolved
* Also removed locale from some links

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
sdk/identity/Azure.Identity/README.md Outdated Show resolved Hide resolved
sdk/identity/Azure.Identity/README.md Outdated Show resolved Hide resolved
sdk/identity/Azure.Identity/README.md Outdated Show resolved Hide resolved
sdk/identity/Azure.Identity/README.md Outdated Show resolved Hide resolved
sdk/identity/Azure.Identity/README.md Outdated Show resolved Hide resolved
sdk/identity/Azure.Identity/README.md Outdated Show resolved Hide resolved
pvaneck and others added 2 commits October 18, 2022 16:56
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
@jsquire jsquire dismissed their stale review October 19, 2022 14:00

This is my review; requested changes were made and I'm removing the block while deferring to others for approval.

Copy link
Member

@scottaddie scottaddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final round of suggestions, and then this PR looks good to me.

sdk/identity/Azure.Identity/README.md Outdated Show resolved Hide resolved
sdk/identity/Azure.Identity/README.md Outdated Show resolved Hide resolved
sdk/identity/Azure.Identity/README.md Outdated Show resolved Hide resolved
sdk/identity/Azure.Identity/README.md Outdated Show resolved Hide resolved
sdk/identity/Azure.Identity/README.md Outdated Show resolved Hide resolved
sdk/identity/Azure.Identity/README.md Outdated Show resolved Hide resolved
sdk/identity/Azure.Identity/TROUBLESHOOTING.md Outdated Show resolved Hide resolved
sdk/identity/Azure.Identity/TROUBLESHOOTING.md Outdated Show resolved Hide resolved
pvaneck and others added 3 commits October 19, 2022 10:38
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
@pvaneck
Copy link
Member Author

pvaneck commented Oct 20, 2022

@schaabs Would like to get your review/approval before merging.

@pvaneck
Copy link
Member Author

pvaneck commented Oct 20, 2022

Thanks all for the reviews. :)

@pvaneck pvaneck merged commit ad0b7e8 into Azure:main Oct 20, 2022
@pvaneck pvaneck deleted the identity-docs branch October 20, 2022 20:39
schaabs pushed a commit to schaabs/azure-sdk-for-net that referenced this pull request Nov 8, 2022
This updates the README and TROUBLESHOOTING files for
greater consistency with other language docs and for general
enhancement. Code snippets were added for the README.

Ref: Azure#31064

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
schaabs added a commit that referenced this pull request Nov 8, 2022
* [Identity] Update documentation (#31867)

This updates the README and TROUBLESHOOTING files for
greater consistency with other language docs and for general
enhancement. Code snippets were added for the README.

Ref: #31064

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

* fix error messages with AADSTS and az login (#31949)

* fix error messages with AADSTS and az login

* Update SharedTokenCacheCredential XML class documentation (#32195)

* [Identity] Class documentation improvements (#32043)

This adds additional details to the docstrings for
some of the credential classes. Users may find the
added info helpful.

Also added missing envvar in README.

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

* Update Azure.Identity changelog (#32216)

* Handle Managed Identity json parse errors as CredentialUnAvailableException (#32272)

* handle json parse errors as CredentialNotAvailable

* update changelog for 1.8.0 release

* update csproj version

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Co-authored-by: Christopher Scott <chriss@microsoft.com>
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this pull request Dec 7, 2022
This updates the README and TROUBLESHOOTING files for
greater consistency with other language docs and for general
enhancement. Code snippets were added for the README.

Ref: Azure#31064

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Identity October Release Doc Consistency Review
5 participants