Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AzureMonitorExporter] Refactor RestClient and DebugWritter #32172

Merged
merged 2 commits into from
Nov 2, 2022
Merged

[AzureMonitorExporter] Refactor RestClient and DebugWritter #32172

merged 2 commits into from
Nov 2, 2022

Conversation

TimothyMothra
Copy link
Contributor

@TimothyMothra TimothyMothra commented Oct 28, 2022 •
edited

Changes

  • refactor RestClient
    • cache the RawRequestUriBuilder to reduce allocations
    • remove dupe code
    • fix SendFromStorage
      This was creating a NDJsonWriter that was never used
  • refactor DebugWritter
    • WriteMessage wasn't writing a new-line.
    • add WriteTelemetryFromStorage to print the ReadOnlyMemory<byte>

image

@TimothyMothra TimothyMothra added the Monitor - Exporter Monitor OpenTelemetry Exporter label Oct 28, 2022
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

vishweshbankwar
vishweshbankwar approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@vishweshbankwar vishweshbankwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Changelog for improved logging will be good.

@TimothyMothra TimothyMothra enabled auto-merge (squash) November 2, 2022 17:30
@TimothyMothra TimothyMothra merged commit fea9a34 into main Nov 2, 2022
@TimothyMothra TimothyMothra deleted the tilee/rest_client branch November 2, 2022 17:48
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this pull request Dec 7, 2022
@TimothyMothra @sofiar-msft
[AzureMonitorExporter] Refactor RestClient and DebugWritter (Azure#32172
a44ebda 
)

* refactor rest client and debugwritter

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishweshbankwar vishweshbankwar vishweshbankwar approved these changes

@cijothomas cijothomas Awaiting requested review from cijothomas cijothomas is a code owner

@reyang reyang Awaiting requested review from reyang reyang is a code owner

@rajkumar-rangaraj rajkumar-rangaraj Awaiting requested review from rajkumar-rangaraj rajkumar-rangaraj is a code owner

Assignees
No one assigned
Labels
Monitor - Exporter Monitor OpenTelemetry Exporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TimothyMothra @azure-sdk @vishweshbankwar