[Cognitive Services] Add .nuspec file to include notice.txt #3290
Conversation
Add .nuspec file to include readme.txt
|
Can one of the admins verify this patch? |
| </metadata> | ||
| <files> | ||
| <file src="bin\release\net452\Microsoft.Azure.Management.CognitiveServices.dll" target="lib\net452" /> | ||
| <file src="bin\release\netstandard1.4\Microsoft.Azure.Management.CognitiveServices.dll" target="lib\netstandard1.4" /> |
There was a problem hiding this comment.
The "src" path works on my local machine but I'm not very sure if I should specify it in this way for "official" build. Please confirm.
There was a problem hiding this comment.
@felixwa were you able to create a nuget and install the new nuget and see the notice get's added to the users Solution in Visual Studio?
There was a problem hiding this comment.
@felixwa a good way to make this change is good is to create a signed nuget package using the signing job to create a signed package and test out in SDK and PowerShell scenarios.
| @@ -0,0 +1,62 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
This .nuspec file is authored based on the file I extracted from Cognitive Services package in nuget.org
| <dependency id="Microsoft.Rest.ClientRuntime" version="[2.3.5, 3.0.0)" /> | ||
| </group> | ||
| <group targetFramework=".NETStandard1.4"> | ||
| <dependency id="Microsoft.NETCore.Platforms" version="[1.1.0, )" /> |
There was a problem hiding this comment.
Not sure if we really need this long dependency list?
Rename readme.txt to notice.txt
felixwa
changed the title
| </metadata> | ||
| <files> | ||
| <file src="bin\release\net452\Microsoft.Azure.Management.CognitiveServices.dll" target="lib\net452" /> | ||
| <file src="bin\release\netstandard1.4\Microsoft.Azure.Management.CognitiveServices.dll" target="lib\netstandard1.4" /> |
There was a problem hiding this comment.
@felixwa were you able to create a nuget and install the new nuget and see the notice get's added to the users Solution in Visual Studio?
|
@azuresdkci add to whitelist |
| </metadata> | ||
| <files> | ||
| <file src="bin\release\net452\Microsoft.Azure.Management.CognitiveServices.dll" target="lib\net452" /> | ||
| <file src="bin\release\netstandard1.4\Microsoft.Azure.Management.CognitiveServices.dll" target="lib\netstandard1.4" /> |
There was a problem hiding this comment.
@felixwa a good way to make this change is good is to create a signed nuget package using the signing job to create a signed package and test out in SDK and PowerShell scenarios.
Apply nuspec from "official" package
Based on Abhijeet's example, adds notice.txt file and nuspec file as ItemGroup in csproj
Remove nuspec file seems like it is not needed
|
@shahabhijeet , I have removed that .nuspec file because I found it is not a must have to include the notice.txt file in the package. You can refer to this build artifacts: http://azuresdkci.cloudapp.net/view/NetCore-SDK/job/NetCore-SDK-Sign/156/ |
Add .nuspec file to include readme.txt
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.