New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event Hubs - Don't pass cancelled token to TryExecute when draining #38067
Conversation
/azp run net - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
API change check API changes are not detected in this pull request. |
sdk/eventhub/Microsoft.Azure.WebJobs.Extensions.EventHubs/src/Listeners/EventHubListener.cs
Outdated
Show resolved
Hide resolved
…Listeners/EventHubListener.cs
…ure-sdk-for-net into eh-ext-stopping
/azp run net - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/eventhub/Microsoft.Azure.WebJobs.Extensions.EventHubs/src/Processor/EventProcessorHost.cs
Outdated
Show resolved
Hide resolved
sdk/eventhub/Microsoft.Azure.WebJobs.Extensions.EventHubs/src/Processor/EventProcessorHost.cs
Outdated
Show resolved
Hide resolved
sdk/eventhub/Microsoft.Azure.WebJobs.Extensions.EventHubs/src/Listeners/EventHubListener.cs
Outdated
Show resolved
Hide resolved
sdk/eventhub/Microsoft.Azure.WebJobs.Extensions.EventHubs/src/Processor/EventProcessorHost.cs
Outdated
Show resolved
Hide resolved
/azp run net - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
...soft.Azure.WebJobs.Extensions.EventHubs/src/Listeners/EventHubListener.PartitionProcessor.cs
Outdated
Show resolved
Hide resolved
/azp run net - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
Event Hubs version of #38063
Also fixed up the Cancel/Dispose behavior to better align with SB (and our understanding of what the correct behavior should be).
Checkpointing behavior updated so that we will checkpoint the final event when shutting down as long as we are in drain mode. If not in drain mode, we will continue to NOT checkpoint when shutting down.