Feature: Support for Custom Endpoint in OpenAIClient #41242
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangyuxiaowu
requested review from
jpalvarezl,
trrwilson,
joseharriaga and
m-nash
as code owners
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @sangyuxiaowu! We will review the pull request and get back to you soon. |
sangyuxiaowu
requested review from
KrzysztofCwalina and
tg-msft
as code owners
|
@microsoft-github-policy-service agree |
|
Hi @sangyuxiaowu. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
github-actions
bot
added
the
no-recent-activity
github-actions
bot
removed
the
no-recent-activity
jalleeeee
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue #4152 and #39284, which request the ability to connect to custom endpoints that expose an OpenAI compatible API using the
OpenAIClientclass.Changes:
SetIsConfiguredForAzureOpenAIwas added to theOpenAIClientclass. This method allows setting the value of the private field_isConfiguredForAzureOpenAI, enabling the client to connect to any endpoint.This change will make it possible for the Semantic Kernel to interact with hosted Open Source models with technologies like vLLM, llama.cpp, etc., and allow applications to specify the Endpoint, useful in cases where applications cannot directly access OpenAI’s official endpoints and need to use an intermediary server for filtering.
Please review and let me know if any changes are required.