-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass attributes defined in the ResourceBuilder along with azure monitor telemetry #41868
fix: pass attributes defined in the ResourceBuilder along with azure monitor telemetry #41868
Conversation
Thank you for your contribution @mumby0168! We will review the pull request and get back to you soon. |
@microsoft-github-policy-service agree |
...nitor.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Demo/Logs/LogDemo.cs
Outdated
Show resolved
Hide resolved
…onitor.OpenTelemetry.Exporter.Demo/Logs/LogDemo.cs Co-authored-by: Robert Bennett <robertbennett1998@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supporting Resource should be coordinated with other languages as well, and need some spec/mapping defined before implementing.
See previous PR which also details the need for design first : #36027
Hi, who is this sat with at the moment is this within Microsoft or in the wider OTEL community? Is there an option to wrap this in an experimental feature or via configuration potentially so people can opt in at there own will? Thanks, |
This is a pure Microsoft/Azure Monitor decision, nothing to do with OTel community. |
Is this on-going and due anytime soon, or anything that can be done to get an ETA? |
@mattmccleary Is there an ETA we can provide? |
No dates yet, it's on the agenda to discuss w/ our backend team to ensure we are aligned w/ upcoming changes to how resource metadata is stored in Log Analytics and used to power experiences in Azure Monitor. |
Hi @mumby0168. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Hi @mumby0168. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
Closes #40951 #40630 #35487
This is my first PR to this area, I have read the guide but anything I need to add please let me know :)
One question I do have, is that the idea of OTEL and the resource attributes are sent once per batch of signals, I know this PR sends it per telemetry item, is there another option or is this not supported by the azure monitor SDK?