Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass attributes defined in the ResourceBuilder along with azure monitor telemetry #41868

Closed

Conversation

mumby0168
Copy link

@mumby0168 mumby0168 commented Feb 9, 2024

Closes #40951 #40630 #35487

This is my first PR to this area, I have read the guide but anything I need to add please let me know :)

One question I do have, is that the idea of OTEL and the resource attributes are sent once per batch of signals, I know this PR sends it per telemetry item, is there another option or is this not supported by the azure monitor SDK?

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter labels Feb 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

Thank you for your contribution @mumby0168! We will review the pull request and get back to you soon.

@mumby0168
Copy link
Author

@mumby0168 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

…onitor.OpenTelemetry.Exporter.Demo/Logs/LogDemo.cs

Co-authored-by: Robert Bennett <robertbennett1998@outlook.com>
Copy link
Contributor

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supporting Resource should be coordinated with other languages as well, and need some spec/mapping defined before implementing.

See previous PR which also details the need for design first : #36027

@mumby0168
Copy link
Author

Supporting Resource should be coordinated with other languages as well, and need some spec/mapping defined before implementing.

See previous PR which also details the need for design first : #36027

Hi, who is this sat with at the moment is this within Microsoft or in the wider OTEL community?

Is there an option to wrap this in an experimental feature or via configuration potentially so people can opt in at there own will?

Thanks,
Billy

@cijothomas
Copy link
Contributor

This is a pure Microsoft/Azure Monitor decision, nothing to do with OTel community.

@mumby0168
Copy link
Author

This is a pure Microsoft/Azure Monitor decision, nothing to do with OTel community.

Is this on-going and due anytime soon, or anything that can be done to get an ETA?

@cijothomas
Copy link
Contributor

This is a pure Microsoft/Azure Monitor decision, nothing to do with OTel community.

Is this on-going and due anytime soon, or anything that can be done to get an ETA?

@mattmccleary Is there an ETA we can provide?

@mattmccleary
Copy link
Member

This is a pure Microsoft/Azure Monitor decision, nothing to do with OTel community.

Is this on-going and due anytime soon, or anything that can be done to get an ETA?

@mattmccleary Is there an ETA we can provide?

No dates yet, it's on the agenda to discuss w/ our backend team to ensure we are aligned w/ upcoming changes to how resource metadata is stored in Log Analytics and used to power experiences in Azure Monitor.
FYI - @OsvaldoRosado

Copy link

Hi @mumby0168. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Apr 19, 2024
Copy link

Hi @mumby0168. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter no-recent-activity There has been no recent activity on this issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] OpenTelemetry logging not passing Resource attributes
4 participants