[AzureMonitorDistro] upgrade OpenTelemetry for hotfix #43432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyMothra
requested review from
JoshLove-msft,
christothes,
annelo-msft,
KrzysztofCwalina,
tg-msft,
jsquire,
pallavit,
m-nash,
ArthurMa1978,
cijothomas,
reyang,
rajkumar-rangaraj and
vishweshbankwar
as code owners
jsquire
approved these changes
Apr 15, 2024
vishweshbankwar
approved these changes
Apr 15, 2024
|
API change check API changes are not detected in this pull request. |
cijothomas
reviewed
Apr 15, 2024
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/CHANGELOG.md
Outdated
Show resolved
Hide resolved
|
Updated the changelog with the quote from the OTel changelog. |
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/CHANGELOG.md
Outdated
Show resolved
Hide resolved
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/CHANGELOG.md
Outdated
Show resolved
Hide resolved
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/CHANGELOG.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com>
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/CHANGELOG.md
Outdated
Show resolved
Hide resolved
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/CHANGELOG.md
Outdated
Show resolved
Hide resolved
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/CHANGELOG.md
Outdated
Show resolved
Hide resolved
|
I suggest we overwrite the default redaction in the instrumentation library and continue with the same behavior UNTIL OpenTelemetry makes a spec change. This minimizes the risk of giving our customers whip lash on a behavior that has been standard in Application Insight for most/all of its existence and ensures we have a consistent product position across languages. |
+1 on keeping the existing behavior for now |
|
Changing this to Draft. Need to make some changes. Will aim to get this merged by tomorrow (Fri) morning. |
reyang
reviewed
Apr 26, 2024
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/CHANGELOG.md
Outdated
Show resolved
Hide resolved
TimothyMothra
merged commit f5b43e5
into
hotfix/azure.monitor.opentelemetry.aspnetcore_1.1.1
6 of 41 checks passed
|
Thank you! |
TimothyMothra
added a commit
that referenced
this pull request
Apr 29, 2024
* [AzureMonitorDistro] upgrade OpenTelemetry for hotfix (#43432) * hotfix * update changelog * update other packages as well * Update sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/CHANGELOG.md Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com> * update changelog with feedback * fix link * add link to breaking changes section * change Distro to override Disable * update changelog * update changelog * update changelog * typo * update changelog --------- Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com> * fix broken link * fix broken link * update changelog * edit changelog --------- Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this PR so our team can review these changes.
Hotfix
I created a new
hotfix/azure.monitor.opentelemetry.aspnetcore_1.1.1, forked from tag/Azure.Monitor.OpenTelemetry.AspNetCore_1.1.0Our hotfix will release from this branch.
This PR is merging into this branch.
Changes
This PR is upgrades the OpenTelemetry dependencies to 1.8.1.