Fix Azure OpenAI double ?, and JSON test issues #44457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ralph-msft
commented
Jun 7, 2024
ralph-msft
commented
- Fixes the double ? between that path and query string in the URI that was causing the Azure OpenAI service to fail the requests with HTTP 404 errors
- Fixes some of the test issues with the downgrade from version 8.X to 4.X of System.Text.Json
- Improves the reliability of VectorStoreTests.CanAssociateFiles
- Fixes JSON issues due to moving to older JSON version - Fixes vector store test that was subject to race condition in status
ralph-msft
requested review from
jpalvarezl,
trrwilson,
joseharriaga and
m-nash
as code owners
|
API change check API changes are not detected in this pull request. |
trrwilson
reviewed
Jun 10, 2024
sdk/openai/Azure.AI.OpenAI/src/Generated/Internal/ClientUriBuilder.cs
Outdated
Show resolved
Hide resolved
NOTE: This only fixes the issue for Azure OpenAI. A proper fix will require updates to the autogenerated code which will in a later PR
trrwilson
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.