Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Newtonsoft] Publish version of SQL for preview branch #4972

Merged
merged 4 commits into from Nov 2, 2018
Merged

[Newtonsoft] Publish version of SQL for preview branch #4972

merged 4 commits into from Nov 2, 2018

Conversation

maddieclayton
Copy link
Contributor

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@maddieclayton
Copy link
Contributor Author

Need to fix a test, will be ready for merge in an hour

@maddieclayton
Copy link
Contributor Author

ready for merge.

@maddieclayton
Copy link
Contributor Author

@maddieclayton maddieclayton merged commit f56ca51 into Azure:sqlpreviewupdate Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants