NFSAAS-2235 update to RP V3.5 (#7) #5660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Again. With clean master.
Again. With clean master.
|
@leonardbf props for the clean commit history 👍 |
dsgouda
suggested changes
Apr 2, 2019
| Version 0.9.1-preview relates to NetApp Files (ANF) RP R3 | ||
| - Addition of export policy for volumes | ||
| - Addition of active directory for accounts | ||
| Version 0.9.0-preview relates to NetApp Files (ANF) RP R2 |
There was a problem hiding this comment.
nit: You don't need to explain what previous versions of the package do.,
There was a problem hiding this comment.
Ok. I'll keep this in mind but would like to leave it here this time.
| @@ -35,5 +35,5 @@ | |||
| // You can specify all the values or you can default the Build and Revision Numbers | |||
| // by using the '*' as shown below: | |||
| // [assembly: AssemblyVersion("1.0.*")] | |||
| [assembly: AssemblyVersion("1.0.0.0")] | |||
| [assembly: AssemblyFileVersion("1.0.0.0")] | |||
| [assembly: AssemblyVersion("1.1.0.0")] | |||
There was a problem hiding this comment.
Test project versions are always set to 1.0.0.0 and never modified
| @@ -143,8 +143,15 @@ public void PatchSnapshot() | |||
| Tags = dict | |||
| }; | |||
|
|
|||
| var resource = netAppMgmtClient.Snapshots.Update(snapshotPatch, ResourceUtils.resourceGroup, ResourceUtils.accountName1, ResourceUtils.poolName1, ResourceUtils.volumeName1, ResourceUtils.snapshotName1); | |||
| Assert.True(resource.Tags.ToString().Contains("Tag1") && resource.Tags.ToString().Contains("Value1")); | |||
| try | |||
There was a problem hiding this comment.
nit: Consider using Assert.Throws here
There was a problem hiding this comment.
ok. If it's acceptable I will look at this for the next version which is gated GA in the next few weeks.
dsgouda
approved these changes
Apr 2, 2019
|
@azuresdkci test this please |
|
@leonardbf please join the azure github org here in order to kick off this build |
mentat9
pushed a commit
to mentat9/azure-sdk-for-net
that referenced
this pull request
Jun 10, 2019
* NFSAAS-2235 update to RP V3.5 Again. With clean master. * NFSAAS-2235 update to RP V3.5 (Azure#7) Again. With clean master. * NFSAAS-2235 update from review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again. With clean master.
Update SDK to version R3.5 of RP.
Includes active directory and export policy.
Still in preview - breaking changes are not an issue
Swagger:
https://github.com/leonardbf/azure-rest-api-specs/tree/master/specification/netapp/resource-manager
Last swagger PR:
Azure/azure-rest-api-specs#5446
This replaces #5646
(NetApp internal ticket NFSAAS-2235)