Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ServiceBus] Do a pass over logging. Ensure parity with EventHub for min-bar. #14339

Closed
KieranBrantnerMagee opened this issue Oct 7, 2020 · 1 comment
Closed

[ServiceBus] Do a pass over logging. Ensure parity with EventHub for min-bar. #14339

KieranBrantnerMagee opened this issue Oct 7, 2020 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Milestone
Backlog

Comments

@KieranBrantnerMagee
Copy link
Member

pre-GA-release fit and finish.

Ensure we have useful logging telemetry for users. If seeking inspiration on "what is too much/not enough", use EventHub as an example.
@KieranBrantnerMagee KieranBrantnerMagee added Service Bus Client This issue points to a problem in the data-plane of the library. labels Oct 7, 2020
@KieranBrantnerMagee KieranBrantnerMagee added this to the [2020] November milestone Oct 7, 2020
@yunhaoling yunhaoling modified the milestones: [2020] December, Backlog Dec 8, 2020
@yunhaoling
Copy link
Contributor

closing this issue as service bus is already GAed :)

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue May 10, 2021
@VMMicrosoft @rewongmicrosoft
@brandong-ms @akning-ms
CodeGen from PR 14339 in Azure/azure-rest-api-specs
12362e6 
Release microsoft.sql 2021 02 01 preview (Azure#14339)

* Adds base for updating Microsoft.Sql from version preview/2020-11-01-preview to version 2021-02-01-preview

* Updates readme

* Updates API version in new specs and examples

* Fix Integer format: S360 swagger lint issues in 2021-02-01 (Azure#13855)

* Update integer format

* update typo

* Swagger Documentation for Outbound Firewall Rules (Azure#13820)

* Swagger Documentation for Outbound Firewall Rules

* Add the new file to v5

Co-authored-by: Vineet Mahadik <Vineet.Mahadik@microsoft.com>

* Swagger Documentation For Database Resource With Ledger (Azure#13916)

* adding database swagger files

* modifying example

* Fixing to be boolean

* adding database extensions and database operations

* adding other database examples

* removing database_legacy, adding usages

* removing usages

* removing databases_legacy from readme

* Swagger Documentation For Ledger Digest Upload (Azure#13871)

* adding ledger api

* Fixes from validation

* removing required endpoint parameter, adding ledgerName (current) to id

* removing 201 response from resource, renaming ledgerName

* adding location to 202 results

* fixing 202 response location

* renaming files

* updating files with new controller name + correct entity name

* fixing readme

* Dev brandong getrestorabledropped (Azure#14129)

* Update RestorableDroppedDatabases API to add BackupStorageAccountType property

* Update readme.md

* Re-add elasticPoolId as a deprecated property

* Update elasticPoolId description and remove trailing comma causing failures

* Remove the unsupported deprecated property

* Add 2021-02-01-preview minor changes (Azure#13942)

* add 2021-02-01-preview for test

* update with 2021-04-19 latest

* update readme.md

* update with latest master in DSMainDev

* Carry IsInfraEncryptionEnabled to Database.json (Azure#14322)

* carry latest minor changes.

* re-format readme.md

* remove 2020 11 01 RestorableDroppedManagedDatabases in V5

* Update readme file in 2021 02 01 dev branch to match the master branch (Azure#14336)

* Carry IsInfraEncryptionEnabled to Database.json (Azure#14322)

* carry latest minor changes.

* re-format readme.md

* remove 2020 11 01 RestorableDroppedManagedDatabases in V5

* update to match master branch readme.md

Co-authored-by: Vineet Mahadik <44247873+VMMicrosoft@users.noreply.github.com>
Co-authored-by: Vineet Mahadik <Vineet.Mahadik@microsoft.com>
Co-authored-by: rewongmicrosoft <57964114+rewongmicrosoft@users.noreply.github.com>
Co-authored-by: brandong-ms <44618010+brandong-ms@users.noreply.github.com>
Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@ramya-rao-a @KieranBrantnerMagee @yunhaoling