Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] RequestIdPolicy still setting x-ms-client-request id if present in request headers #17757

Closed
iscai-msft opened this issue Apr 1, 2021 · 1 comment
Closed

[core] RequestIdPolicy still setting x-ms-client-request id if present in request headers #17757

iscai-msft opened this issue Apr 1, 2021 · 1 comment
Assignees
@iscai-msft
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Milestone
[2021] July

Comments

@iscai-msft
Copy link
Contributor

Currently, RequestIdPolicy only looks inside PipelineContext.options to see if x-ms-client-request-id is set. I think it should also check if it's already set in the request headers before creating a new one
@iscai-msft iscai-msft added Client This issue points to a problem in the data-plane of the library. Azure.Core labels Apr 1, 2021
@iscai-msft iscai-msft added this to the [2021] May milestone Apr 1, 2021
@iscai-msft iscai-msft self-assigned this Apr 1, 2021
@iscai-msft iscai-msft mentioned this issue Apr 1, 2021
Closed
@lmazuel lmazuel modified the milestones: [2021] May, [2021] June May 25, 2021
@iscai-msft iscai-msft modified the milestones: [2021] June, [2021] July Jun 18, 2021
@xiangyan99 xiangyan99 mentioned this issue Jul 12, 2021
Merged
@xiangyan99
Copy link
Member

Fixed.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Feb 14, 2022
@msyyc
CodeGen from PR 17757 in Azure/azure-rest-api-specs
f727843 
Add x-ms-identifiers for datalake-store (Azure#17757)

* Add x-ms-identifiers for datalake-store

* Update readme.python.md

* Update readme.md

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iscai-msft iscai-msft

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2021] July
Development

Successfully merging a pull request may close this issue.

[core] check request id in request headers iscai-msft/azure-sdk-for-python
3 participants
@lmazuel @xiangyan99 @iscai-msft