Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault] Address remaining architect feedback for keys #22981

Closed
5 tasks done
mccoyp opened this issue Feb 8, 2022 · 0 comments · Fixed by #23286
Closed
5 tasks done

[Key Vault] Address remaining architect feedback for keys #22981

mccoyp opened this issue Feb 8, 2022 · 0 comments · Fixed by #23286
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone

Comments

@mccoyp
Copy link
Member

mccoyp commented Feb 8, 2022

Per the most recent round of feedback for azure-keyvault-keys, we need to take a look at a few more pieces of feedback before the upcoming stable release:

  • Move the optional version parameter in KeyClient.release_key into keyword-only arguments
  • Try to get update_key_rotation_policy and get_key_rotation_policy to round-trip
    • "If I get a rotation policy - I should be able to pass that back in again, with optional kwargs to overwrite specific attributes."
  • Compare key encryption algorithm enums with cryptography names and align where possible
    • cryptography uses aes_key_wrap as the algorithm name and doesn't provide different versions based on number of bytes. For the sake of differentiating our algorithms, and because ckm_rsa_aes_key_wrap is a standard algorithm name in the space, we can keep our KeyExportEncryptionAlgorithm value names. Other algorithms are unchanged and standard
  • Make all enums consistently lower-case
  • Rename name parameter in KeyClient.get_key_rotation_policy and KeyClient.update_key_rotation_policy to key_name
@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. labels Feb 8, 2022
@mccoyp mccoyp added this to the [2022] March milestone Feb 8, 2022
@mccoyp mccoyp self-assigned this Feb 8, 2022
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this issue Mar 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant