Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OpenTelemetry instrumentation grpc #32496

Open
jeremydvoss opened this issue Oct 13, 2023 · 3 comments
Open

Support for OpenTelemetry instrumentation grpc #32496

jeremydvoss opened this issue Oct 13, 2023 · 3 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Monitor - ApplicationInsights Monitor - Distro Monitor OpenTelemetry Distro OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)

Comments

@jeremydvoss
Copy link
Member

Migrated from ApplicationInsights-Python

Hello, may I ask whether you could add support for grpc instrumentation? Thanks.

[1] https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation/opentelemetry-instrumentation-grpc

Current status:
This is not currently a estimated date at which point this will be added as part of the distro. However, you can still trigger the instrumentation yourself after calling configure_azure_monitor. For instance, SQLAlchemy is not a part of the distro, but you can still use it with the distro. See the associated sample here

@jeremydvoss jeremydvoss added the Monitor - Distro Monitor OpenTelemetry Distro label Oct 13, 2023
@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. Monitor - ApplicationInsights needs-team-triage Workflow: This issue needs the team to triage. labels Oct 13, 2023
@jeremydvoss jeremydvoss added the OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific) label Oct 13, 2023
@xiangyan99 xiangyan99 removed the needs-team-triage Workflow: This issue needs the team to triage. label Oct 16, 2023
@lzchen lzchen added the feature-request This issue requires a new behavior in the product in order be resolved. label Oct 16, 2023
@lzchen lzchen assigned lzchen and unassigned pvaneck Oct 16, 2023
@yli02
Copy link

yli02 commented Apr 16, 2024

Hi @jeremydvoss and @lzchen , may I ask whether there is any plan to support this feature request? Thanks.

FYI, the provided link for sample here is broken.

@lzchen
Copy link
Member

lzchen commented Apr 17, 2024

@yli02

No immediate plans currently. Here is the updated link to the sample.

@yli02
Copy link

yli02 commented Apr 17, 2024

@lzchen , thanks for the info.

The following setup seems working fine with us so far.

configure_azure_monitor()

grpc_client_instrumentor = GrpcInstrumentorClient()
grpc_client_instrumentor.instrument()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Monitor - ApplicationInsights Monitor - Distro Monitor OpenTelemetry Distro OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)
Projects
None yet
Development

No branches or pull requests

5 participants