Shared credential #10509
Merged
Shared credential #10509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
added
Client
iscai-msft
requested review from
lmazuel,
bryevdv,
maririos,
chlowell,
xiangyan99 and
kristapratico
|
Can one of the admins verify this patch? |
maririos
reviewed
Mar 26, 2020
maririos
reviewed
Mar 26, 2020
…into shared_credential * 'master' of https://github.com/Azure/azure-sdk-for-python: regenerated resource graph (Azure#10450) Release azure mgmt rdbms (Azure#10498) [Compute] Manual release for 2019-12-01 (Azure#10433) Wrap variable length time.sleeps in a helper such that they don't fail if already expired. (Azure#10511) Move archetype-python-release.yml into the public repo (Azure#10212) Give complete response to IMDS probe in tests (Azure#10504) Fix failing servicebus tests (Azure#10457) Sync eng/common directory with azure-sdk-tools repository (Azure#10506)
johanste
reviewed
Mar 26, 2020
johanste
reviewed
Mar 26, 2020
johanste
reviewed
Mar 26, 2020
sdk/core/azure-core/azure/core/pipeline/policies/_authentication.py
Outdated
Show resolved
Hide resolved
johanste
reviewed
Mar 26, 2020
sdk/core/azure-core/azure/core/pipeline/policies/_authentication.py
Outdated
Show resolved
Hide resolved
maririos
previously approved these changes
Mar 26, 2020
xiangyan99
reviewed
Mar 27, 2020
…into shared_credential * 'master' of https://github.com/Azure/azure-sdk-for-python: Update install link [Event Hubs] Put uamqp.Message.properties into EventData.system_properties (Azure#10508) Sync eng/common directory with azure-sdk-tools repository (Azure#10531) Prevent DefaultAzureCredential changing authentication method (Azure#10349) Update Batch Data plane (Azure#10477)
maririos
previously approved these changes
Mar 27, 2020
xiangyan99
previously approved these changes
Mar 27, 2020
chlowell
reviewed
Mar 27, 2020
| @@ -28,3 +29,45 @@ def get_token(self, *scopes, **kwargs): | |||
| from collections import namedtuple | |||
|
|
|||
| AccessToken = namedtuple("AccessToken", ["token", "expires_on"]) | |||
|
|
|||
| __all__ = ["AzureKeyCredential"] | |||
There was a problem hiding this comment.
What's this for? AccessToken is public.
There was a problem hiding this comment.
Then AccessToken should also be in __all__
There was a problem hiding this comment.
added AccessToken to the all in credentials.py
johanste
previously approved these changes
Mar 27, 2020
iscai-msft
dismissed stale reviews from johanste, xiangyan99, and maririos
via
24035c5
johanste
approved these changes
Mar 30, 2020
maririos
approved these changes
Mar 30, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 30, 2020
…into shared_credential_ta * 'master' of https://github.com/Azure/azure-sdk-for-python: Shared credential (Azure#10509) Sync eng/common directory with azure-sdk-tools repository (Azure#10557) add back preparer (Azure#10558) initial release (Azure#10545) Release azure mgmt storage (Azure#10525) [Event Hubs] Update sample README to use absolute path (Azure#10556) Sync eng/common directory with azure-sdk-tools repository (Azure#10550) update the javascript to currectly select the latest version as if we're in the latest folder (Azure#10544) ensure the change doesn't break anything (Azure#10541) locking dev reqs (Azure#10536) removed await_prepared_test from async tests (Azure#10548)
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 30, 2020
…into shared_credential_search * 'master' of https://github.com/Azure/azure-sdk-for-python: Shared credential (Azure#10509) Sync eng/common directory with azure-sdk-tools repository (Azure#10557) add back preparer (Azure#10558) initial release (Azure#10545) Release azure mgmt storage (Azure#10525) [Event Hubs] Update sample README to use absolute path (Azure#10556) Sync eng/common directory with azure-sdk-tools repository (Azure#10550) update the javascript to currectly select the latest version as if we're in the latest folder (Azure#10544) ensure the change doesn't break anything (Azure#10541) locking dev reqs (Azure#10536) removed await_prepared_test from async tests (Azure#10548)
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 31, 2020
…into regenerate_v3_ta * 'master' of https://github.com/Azure/azure-sdk-for-python: [text analytics] Use AzureKeyCredential from core instead of TextAnalyticsKeyCredential (Azure#10528) Enable TransportType.AmqpOverWebsocket for ServiceBus (Azure#10012) Install tools packages in dev requirements from regression test branch (Azure#10575) Sync eng/common directory with azure-sdk-tools repository (Azure#10570) Shared credential (Azure#10509) Sync eng/common directory with azure-sdk-tools repository (Azure#10557) add back preparer (Azure#10558) initial release (Azure#10545) Release azure mgmt storage (Azure#10525) [Event Hubs] Update sample README to use absolute path (Azure#10556) Sync eng/common directory with azure-sdk-tools repository (Azure#10550)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a shared AzureKeyCredential and AzureKeyCredentialPolicy
Will create later PRs in TextAnalytics and Search that use this AzureKeyCredential instead of their own key credentials
fixes #10529