[KeyVault] Add Status Methods to Query Backup and Restore Operations #14158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccoyp
added
KeyVault
Client
mccoyp
requested review from
sadasant,
christothes,
JonathanGiles,
heaths,
g2vinay,
vcolin7,
AlexGhiondea,
chlowell and
schaabs
chlowell
reviewed
Oct 1, 2020
...eyvault-administration/tests/recordings/test_backup_client.test_full_backup_and_restore.yaml
Outdated
Show resolved
Hide resolved
| @@ -61,14 +75,28 @@ def test_selective_key_restore(self, container_uri, sas_token): | |||
| # backup the vault | |||
| backup_client = KeyVaultBackupClient(self.managed_hsm["url"], self.credential) | |||
| backup_poller = backup_client.begin_full_backup(container_uri, sas_token) | |||
|
|
|||
| # check backup status and result | |||
| job_id = backup_poller.polling_method().resource().id | |||
There was a problem hiding this comment.
#14169 tracks improving this
| return await self._client.restore_status( | ||
| vault_base_url=self._vault_url, | ||
| job_id=job_id, | ||
| cls=RestoreOperation._wrap_generated, |
There was a problem hiding this comment.
Just a general comment with no action for this PR: interestingly, we can't learn whether the operation is selective from the job ID or the service's status response. We therefore can't know whether to choose RestoreOperation or SelectiveKeyRestoreOperation here. Further reason to merge those classes, I suppose.
sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_backup_client.py
Outdated
Show resolved
Hide resolved
mccoyp
requested review from
johanste,
kristapratico,
lmazuel,
rakshith91 and
xiangyan99
as code owners
mccoyp
removed request for
lmazuel,
rakshith91,
xiangyan99,
johanste and
kristapratico
johanste
reviewed
Oct 2, 2020
chlowell
approved these changes
Oct 2, 2020
iscai-msft
added a commit
that referenced
this pull request
Oct 7, 2020
…into fr-business-cards * 'master' of https://github.com/Azure/azure-sdk-for-python: (71 commits) move the environment prep above the tooling that needs it (#14246) Increment version for appconfiguration releases (#14245) Azure Communication Service - Phone Number Administration (#14237) [text analytics] fix query param in cli call to get endpoint (#14243) Resolve Failing Documentation Build for azure-mgmt-core (#14239) Add code reviewers (#14229) [ServiceBus] make amqp_message properties read-only (#14095) [ServiceBus]remove topic parameter object settability (#14116) app config owner (#12986) [KeyVault] Handle Role Definition UUID Name Internally (#14218) Increment version for storage releases (#14224) Update Key Vault changelogs for October release (#14226) [ServiceBus] CI Test hotfixes (#14195) [text analytics] regen TA with GA autorest (#14215) [Storage][STG74]ChangeLog (#14192) fixes python 2.7 issue with unicode and strings again! (#14216) Feature/storage stg74 (#14175) Update communication pacakges to version b2 (#14209) [KeyVault] Add Status Methods to Query Backup and Restore Operations (#14158) Update buffered sender (#13851) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13718.
Adds methods to
KeyVaultBackupClientfor checking backup and restore operation status. We may want to create a new polling class to make getting job IDs (that are necessary for these methods) easier to obtain.