Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoRelease] t2-resourcegraph-2021-03-31-51385 #17692

Merged
merged 8 commits into from
Apr 8, 2021

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented Mar 31, 2021

@RAY-316 RAY-316 removed the request for review from changlong-liu March 31, 2021 06:26
Yan Zhang (WICRESOFT NORTH AMERICA LTD) added 2 commits March 31, 2021 15:20
@fenwickt
Copy link

Hi,

I believe basic query and facet query tests are failing because in the new api version we've changed the default output format to be an object array (basically json), while tests are still expecting the table format.

For a quick fix, please add options param to both test_resources_basic_query and test_resources_facet_query:
query = QueryRequest(
query='project id, tags, properties | limit 2',
subscriptions=[self.settings.SUBSCRIPTION_ID],
options=QueryRequestOptions(
result_format=ResultFormat.table
), ...)

I will revisit these tests later and update them accordingly to the changes.

@fenwickt
Copy link

fenwickt commented Apr 1, 2021

@msyyc please let me know whether the tests are a blocker for releasing the library and if I can help with anything.

@zhangyan133
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@zhangyan133 zhangyan133 changed the title [AutoRelease] t2-resourcegraph-2021-03-31-51385(Do not merge) [AutoRelease] t2-resourcegraph-2021-03-31-51385 Apr 7, 2021
@zhangyan133
Copy link
Contributor

/check-enforcer override

@zhangyan133 zhangyan133 merged commit d34872c into Azure:master Apr 8, 2021
mccoyp pushed a commit to mccoyp/azure-sdk-for-python that referenced this pull request Apr 9, 2021
* CodeGen from PR 13715 in Azure/azure-rest-api-specs
resourcegraph readme t2 config (Azure#13715)

* version,CHANGELOG

* test

* fix test

* fix test again

* skip test

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com>
mccoyp pushed a commit to mccoyp/azure-sdk-for-python that referenced this pull request Apr 13, 2021
* CodeGen from PR 13715 in Azure/azure-rest-api-specs
resourcegraph readme t2 config (Azure#13715)

* version,CHANGELOG

* test

* fix test

* fix test again

* skip test

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com>
benbp pushed a commit to benbp/azure-sdk-for-python that referenced this pull request Apr 19, 2021
* CodeGen from PR 13715 in Azure/azure-rest-api-specs
resourcegraph readme t2 config (Azure#13715)

* version,CHANGELOG

* test

* fix test

* fix test again

* skip test

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <v-yanzhang@microsoft.com>
@msyyc msyyc deleted the t2-resourcegraph-2021-03-31-51385 branch November 25, 2021 07:33
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Mar 11, 2022
Adding force delete flag for Network Manager resources (Azure#17692)

* base commit for PR reviewer

* add force delete flags and remove recursive delete flags

* security configuration split into admin/user

* split rule collection into admin/user rule collection

* updating examples for security config resources

* update api version

* fix parameter types for security admin conf/rule collection

* removing display name from all definitions and examples

* fix properties of security config examples

* fix network manager connection path

* update readme with complete spec list

Co-authored-by: Jared Gorthy <jaredgorthy@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants