Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ServiceBus&EventHubs] fix mypy 0.931 errors #23017

Merged

Conversation

swathipil
Copy link
Member

follow up to #22891

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-servicebus. You can review API changes here

API changes

+     property message_state: int    # Read-only
-     property state: ServiceBusMessageState    # Read-only
-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000023A36677070>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001D54379B070>, 
-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000023A36159D20>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001D543289D20>, 

@swathipil
Copy link
Member Author

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-servicebus. You can review API changes here

API changes

+     property message_state: int    # Read-only
-     property state: ServiceBusMessageState    # Read-only
-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001DC5D54F6D0>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000023BF932A170>, 
-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001DC5D026E90>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000023BF8E06E90>, 

@swathipil swathipil merged commit adc3688 into Azure:feature/mypy-update Feb 15, 2022
@swathipil swathipil deleted the swathipil/feature/mypy-update branch February 15, 2022 23:21
@swathipil swathipil linked an issue Feb 16, 2022 that may be closed by this pull request
lmazuel pushed a commit that referenced this pull request Feb 23, 2022
* update mypy pinned version to 0.931 and include types deps

* update mypy checks to be run with python 3.10 in CI

* let mypy install the third-party package stubs it needs at runtime

* pin type stub versions needed and update ignore flag

* [ServiceBus&EventHubs] fix mypy 0.931 errors (#23017)

* fix mypy 0.931 errors

* update tuple naming

* fix mypy errors with latest version of mypy (#23093)

* correct mypy errors arising from latest mypy version (#23114)

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
* update mypy pinned version to 0.931 and include types deps

* update mypy checks to be run with python 3.10 in CI

* let mypy install the third-party package stubs it needs at runtime

* pin type stub versions needed and update ignore flag

* [ServiceBus&EventHubs] fix mypy 0.931 errors (Azure#23017)

* fix mypy 0.931 errors

* update tuple naming

* fix mypy errors with latest version of mypy (Azure#23093)

* correct mypy errors arising from latest mypy version (Azure#23114)

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ServiceBus&EventHubs] fix mypy errors for 0.931
3 participants