New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ServiceBus&EventHubs] fix mypy 0.931 errors #23017
Merged
swathipil
merged 2 commits into
Azure:feature/mypy-update
from
swathipil:swathipil/feature/mypy-update
Feb 15, 2022
Merged
[ServiceBus&EventHubs] fix mypy 0.931 errors #23017
swathipil
merged 2 commits into
Azure:feature/mypy-update
from
swathipil:swathipil/feature/mypy-update
Feb 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swathipil
requested review from
annatisch,
yunhaoling and
rakshith91
as code owners
February 10, 2022 21:21
swathipil
commented
Feb 10, 2022
API changes have been detected in API changes + property message_state: int # Read-only
- property state: ServiceBusMessageState # Read-only
- filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000023A36677070>,
+ filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001D54379B070>,
- filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000023A36159D20>,
+ filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001D543289D20>, |
/azp run python - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
API changes have been detected in API changes + property message_state: int # Read-only
- property state: ServiceBusMessageState # Read-only
- filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001DC5D54F6D0>,
+ filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000023BF932A170>,
- filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001DC5D026E90>,
+ filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000023BF8E06E90>, |
lmazuel
pushed a commit
that referenced
this pull request
Feb 23, 2022
* update mypy pinned version to 0.931 and include types deps * update mypy checks to be run with python 3.10 in CI * let mypy install the third-party package stubs it needs at runtime * pin type stub versions needed and update ignore flag * [ServiceBus&EventHubs] fix mypy 0.931 errors (#23017) * fix mypy 0.931 errors * update tuple naming * fix mypy errors with latest version of mypy (#23093) * correct mypy errors arising from latest mypy version (#23114) Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
* update mypy pinned version to 0.931 and include types deps * update mypy checks to be run with python 3.10 in CI * let mypy install the third-party package stubs it needs at runtime * pin type stub versions needed and update ignore flag * [ServiceBus&EventHubs] fix mypy 0.931 errors (Azure#23017) * fix mypy 0.931 errors * update tuple naming * fix mypy errors with latest version of mypy (Azure#23093) * correct mypy errors arising from latest mypy version (Azure#23114) Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #22891