Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Add progress_hook to file-share upload/download #24997

Merged
merged 3 commits into from
Jun 29, 2022

Conversation

jalauzon-msft
Copy link
Member

Adding the ability to track upload/download progress to file-share just as it was recently done for blob; adding an optional keyword progress_hook to upload_file and download_file.

Resolves #24943

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Jun 28, 2022
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-storage-file-share

Copy link
Member

@vincenttran-msft vincenttran-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just have to fix that typo (which is copied across multiple places, so sorry about that 😛) and we should be golden!

@jalauzon-msft jalauzon-msft enabled auto-merge (squash) June 29, 2022 01:40
@jalauzon-msft
Copy link
Member Author

/check-enforcer override

@jalauzon-msft
Copy link
Member Author

/check-enforcer override

@mikeharder
Copy link
Member

/check-enforcer reset

@jalauzon-msft jalauzon-msft merged commit 155eb8b into Azure:main Jun 29, 2022
@jalauzon-msft jalauzon-msft deleted the file-share-progress-hook branch June 29, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure-storage-file-share file upload/download progress callback is not async safe
4 participants