[Identity] Allow configurable process timeouts #28290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
pvaneck
force-pushed
the
identity-configure-timeout
branch
from
e5c4ed5
to
406ba45
Compare
pvaneck
force-pushed
the
identity-configure-timeout
branch
from
406ba45
to
3acefed
Compare
pvaneck
force-pushed
the
identity-configure-timeout
branch
from
3acefed
to
4b738ff
Compare
pvaneck
force-pushed
the
identity-configure-timeout
branch
from
4b738ff
to
2cb3b43
Compare
AzureCliCredential, AzureDeveloperCliCredential, and AzurePowerShellCredential now allow users to pass in a custom timeout. This addresses scenarios where these proceses can take longer than the current default timeout values. DefaultAzureCredential now also has an optional keyword argument to allow users to pass in timeout values to the underlying developer credentials. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
identity-configure-timeout
branch
from
2cb3b43
to
160552e
Compare
|
@christothes Hey, how's this look naming wise? Consistent naming across individual credentials, with the descriptive name for DAC. |
Looks good to me |
xiangyan99
reviewed
Mar 24, 2023
sdk/identity/azure-identity/azure/identity/_credentials/azd_cli.py
Outdated
Show resolved
Hide resolved
xiangyan99
approved these changes
Mar 24, 2023
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 27, 2023
…into network_ga * 'main' of https://github.com/Azure/azure-sdk-for-python: (63 commits) check only once whether artifact extension exists (Azure#29594) code and test (Azure#29530) fix: support data binding expression for resources.xxx (Azure#29559) code and test (Azure#29558) [ServiceBus] enable sovereign cloud testing (Azure#29202) [AutoRelease] t2-communication-2023-03-20-22792(can only be merged by SDK owner) (Azure#29453) [Identity] Allow configurable process timeouts (Azure#28290) Increment package version after release of azure-containerregistry (Azure#29582) Update optional (Azure#28435) [Monitor][Query] Add sample notebook for large queries (Azure#28148) Update CHANGELOG.md (Azure#29580) [ServiceBus] remove msrest (Azure#29324) Explicitly set PSNativeCommandArgumentPassing to Legacy for git push script (Azure#29554) [ML][Pipelines] Support queue settings in pipeline job (Azure#29209) add experimental decorator for datatransfer (Azure#29562) Featurestore/online store crud new pr (Azure#29546) switch tooling over to typespec (Azure#29501) set up base path for feature set in load function (Azure#29544) Address credential description in docstring (Azure#29549) [Monitor] Regen query and ingestion (Azure#29504) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AzureCliCredential, AzureDeveloperCliCredential, and AzurePowerShellCredential now allow users to pass in a custom timeout. This addresses scenarios where these proceses can take longer than the current default timeout values. DefaultAzureCredential now also has an optional keyword argument to allow users to pass in timeout values to the underlying developer credentials.
process_timeoutto indicate the timeout of the underlying CLI/powerhsell process.developer_credential_timeoutto better indicate that this only applies to a subset of the credentials in the authentication chain (i.e. the developer credentials).Closes: #27509