-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delete all items by partition key functionality #29186
Conversation
Added methods to container and client connection to expose the delete all items by partition key functionality in python.
API change check APIView has identified API level changes in this PR and created following API reviews. |
Added preview functionality to delete items by partition key, added tests and examples. Updated changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just some questions and small suggestions. Would also like it if we had the samples in the document_management.py
files since those deal with all the crud operations. Thanks!
Updated some formatting for newly added methods. Some fixes for testing delete all items by partitionkey. Added examples to document_management.py.
…briz/azure-sdk-for-python into deleteallitemsbypartitionkey
Match is only available after python v 3.10, removed to be more compatible with earlier python versions.
Minor code adjustments to satisfy Pylint
Added PR link to entry for delete all items by partition key in CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Bryan!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @bambriz for feature :)
Fixed issue where passing a None value for partition key caused a 500 http error. Added test for passing invalid partition key values
Description
Add methods to container and client connection to expose the delete all items by partition key functionality in python. If given a valid partition key, it will delete all items belonging to that partition. If a valid partition key is not given, nothing is deleted.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines