[Core][OTel] Support OTel schema versioning #29203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
pvaneck
force-pushed
the
otel-attribute-mapping
branch
from
0dd8303
to
9fa97bf
Compare
This also adds support for attribute mapping to ensure that attributes are mapped to the corresponding semantic convention that we are trying to converge on. Missing network attributes were also added. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
otel-attribute-mapping
branch
from
9fa97bf
to
ebba857
Compare
|
FYI @lmolkova |
pvaneck
requested review from
lmazuel,
annatisch,
johanste,
xiangyan99,
tjprescott,
iscai-msft and
kashifkhan
as code owners
kashifkhan
reviewed
Mar 9, 2023
kashifkhan
approved these changes
Mar 9, 2023
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
otel-attribute-mapping
branch
from
6e6e052
to
2fa811a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for OpenTelemetry scheme versioning, and also adds support for attribute mapping to ensure that attributes are mapped to the corresponding semantic convention that we are trying to converge on.
Missing network attributes were also added in the part where http attributes are added.
Ref: #25838