[Monitor][Query] Support non-public clouds #29602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
scottaddie
reviewed
Mar 27, 2023
sdk/monitor/azure-monitor-query/azure/monitor/query/_logs_query_client.py
Show resolved
Hide resolved
sdk/monitor/azure-monitor-query/azure/monitor/query/aio/_logs_query_client_async.py
Show resolved
Hide resolved
pvaneck
force-pushed
the
query-sovereign-cloud
branch
from
69f66cd
to
36b281f
Compare
|
/azp run python - monitor - tests-weekly |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pvaneck
force-pushed
the
query-sovereign-cloud
branch
from
780dc7f
to
4c512d6
Compare
|
/azp run python - monitor - tests-weekly |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pvaneck
force-pushed
the
query-sovereign-cloud
branch
from
4c512d6
to
b12a764
Compare
sdk/monitor/azure-monitor-query/azure/monitor/query/_logs_query_client.py
Show resolved
Hide resolved
kristapratico
approved these changes
Apr 11, 2023
This adds support and documents non-public cloud usage for LogsQueryClient and MetricsQueryClient. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
query-sovereign-cloud
branch
from
e13569d
to
beb4a14
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support and documents non-public cloud usage for LogsQueryClient and MetricsQueryClient.
There are two URIs we are concerned with:
https://api.loganalytics.io/v1)https://api.loganalytics.io)The endpoint passed in is expected to be the full endpoint including the
v1, and the audience is expected to be the base URL of the endpoint. This logic is added toLogsQueryClient.Also adjust tests to be able to accompany different cloud endpoints.
Verified on Azure China Cloud by running live tests there using the weekly pipeline.
Closes: #27167