[Identity] Check for AADSTS error in CLI-based credentials #30047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvaneck
force-pushed
the
identity-checkout
branch
from
54715e9
to
c55d6b6
Compare
pvaneck
changed the title
|
API change check API changes are not detected in this pull request. |
xiangyan99
reviewed
Jun 1, 2023
|
Hi @pvaneck. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
github-actions
bot
added
the
no-recent-activity
pvaneck
removed
the
no-recent-activity
In some cases, when using the CLI credentials, the error message might contain the "az login" substring, but not really be an error about the user not being logged in. This changes adds a check for "AADSTS" in stderr before giving users the NOT_LOGGED_IN error message. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
identity-checkout
branch
from
c55d6b6
to
4da7a2c
Compare
pvaneck
requested review from
christothes,
billwert,
ahsonkhan,
KarishmaGhiya and
mpodwysocki
xiangyan99
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, when using the CLI credentials, the error message might contain the "az login" substring, but not really be an error about the user not being logged in. This changes adds a check for "AADSTS" in stderr before giving users the NOT_LOGGED_IN error message. .NET does something similar already.
Closes: #29649