Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Evaluating DISTINCT operator before OFFSET/LIMIT #31925

Merged
merged 5 commits into from Sep 5, 2023
Merged

Fix: Evaluating DISTINCT operator before OFFSET/LIMIT #31925

merged 5 commits into from Sep 5, 2023

Conversation

rinatmini
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Cosmos label Sep 1, 2023
@rinatmini rinatmini marked this pull request as ready for review September 1, 2023 21:48
@rinatmini rinatmini self-assigned this Sep 1, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@rinatmini
Copy link
Contributor Author

@simorenoh, @bambriz review please

@simorenoh
Copy link
Member

/azp run python - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rinatmini
Copy link
Contributor Author

/azp run python - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

simorenoh
simorenoh approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@simorenoh simorenoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix Rinat!

@rinatmini rinatmini merged commit df953e3 into main Sep 5, 2023
17 checks passed
@rinatmini rinatmini deleted the users/rinatmini/distinctFix branch September 5, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simorenoh simorenoh simorenoh approved these changes

@kushagraThapar kushagraThapar Awaiting requested review from kushagraThapar kushagraThapar is a code owner

@xinlian12 xinlian12 Awaiting requested review from xinlian12 xinlian12 is a code owner

@annatisch annatisch Awaiting requested review from annatisch annatisch is a code owner

@bambriz bambriz Awaiting requested review from bambriz bambriz is a code owner

Assignees

@rinatmini rinatmini

Labels
Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rinatmini @azure-sdk @simorenoh