Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ServiceBus] update None in network trace params to empty str #32221

Closed

Conversation

swathipil
Copy link
Member

@swathipil swathipil commented Sep 25, 2023

updating as per Anna's comment here: #32190 (comment)

fixes: #32190

TODO:

  • add tests to check _network_trace_params has been updated
  • check with monitor to see if we can repro exact error
  • change all name in pyamqp logging to "azure.amqp" + update docs

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link

github-actions bot commented Dec 1, 2023

Hi @swathipil. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Dec 1, 2023
Copy link

github-actions bot commented Dec 8, 2023

Hi @swathipil. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-recent-activity There has been no recent activity on this issue. Service Bus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SB][pyamqp][OTEL] pyamqp tracing is missing values for amqpLink and amqpSession
2 participants