Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cosmos] transactional batch implementation #32508

Merged
merged 33 commits into from Oct 31, 2023
Merged

[Cosmos] transactional batch implementation #32508

merged 33 commits into from Oct 31, 2023

Conversation

simorenoh
Copy link
Member

@simorenoh simorenoh commented Oct 13, 2023 •
edited

This PR adds transactional batch api to the SDK. From our README:
image

@simorenoh
Copy link
Member Author

/azp run python - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-cosmos

@simorenoh
Copy link
Member Author

/azp run python - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simorenoh
Copy link
Member Author

/azp run python - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simorenoh
Copy link
Member Author

/azp run python - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simorenoh
Copy link
Member Author

/azp run python - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simorenoh
Copy link
Member Author

/azp run python - cosmos - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simorenoh simorenoh marked this pull request as ready for review October 18, 2023 23:18
@simorenoh
Copy link
Member Author

/azp run python - cosmos - tests

@simorenoh
Copy link
Member Author

/azp run python - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simorenoh
Copy link
Member Author

/azp run python - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

annatisch
annatisch reviewed Oct 29, 2023
View reviewed changes
sdk/cosmos/azure-cosmos/azure/cosmos/_cosmos_client_connection.py Outdated Show resolved Hide resolved
sdk/cosmos/azure-cosmos/azure/cosmos/container.py Show resolved Hide resolved
sdk/cosmos/azure-cosmos/azure/cosmos/exceptions.py Outdated Show resolved Hide resolved
sdk/cosmos/azure-cosmos/azure/cosmos/aio/_container.py Outdated Show resolved Hide resolved
sdk/cosmos/azure-cosmos/azure/cosmos/_models.py Outdated Show resolved Hide resolved
sdk/cosmos/azure-cosmos/samples/document_management.py Show resolved Hide resolved
sdk/cosmos/azure-cosmos/azure/cosmos/_models.py Outdated Show resolved Hide resolved
sdk/cosmos/azure-cosmos/samples/document_management.py Outdated Show resolved Hide resolved
sdk/cosmos/azure-cosmos/azure/cosmos/_models.py Outdated Show resolved Hide resolved
sdk/cosmos/azure-cosmos/README.md Outdated Show resolved Hide resolved
@simorenoh
Copy link
Member Author

/azp run python - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simorenoh
Copy link
Member Author

/azp run python - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

annatisch
annatisch approved these changes Oct 30, 2023
View reviewed changes
sdk/cosmos/azure-cosmos/azure/cosmos/_base.py Outdated Show resolved Hide resolved
sdk/cosmos/azure-cosmos/README.md Outdated Show resolved Hide resolved
sdk/cosmos/azure-cosmos/azure/cosmos/exceptions.py Show resolved Hide resolved
simorenoh and others added 2 commits October 30, 2023 16:12
@simorenoh @annatisch
Update sdk/cosmos/azure-cosmos/README.md
0036d0e 
Co-authored-by: Anna Tisch <antisch@microsoft.com>
@simorenoh
address final comments
b1fefc9
@simorenoh
Copy link
Member Author

/azp run python - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simorenoh simorenoh merged commit 814bbb7 into Azure:main Oct 31, 2023
26 checks passed
@simorenoh simorenoh deleted the transactional-batch branch October 31, 2023 05:23
@bambriz bambriz mentioned this pull request Jan 9, 2024
Closed
@davidtingsu
Copy link

davidtingsu commented Mar 12, 2024 •
edited

Is this meant to be publicly available now? I am using poetry to update python dependencies and it's showing 4.5.1 as the latest as of 3/12/2024, but I see the changes are on an unreleased branch 4.5.2b2. Is it stable to use?

@simorenoh
Copy link
Member Author

@davidtingsu We just released a new stable version today with the transactional batch changes: https://pypi.org/project/azure-cosmos/. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinlian12 xinlian12 xinlian12 approved these changes

@bambriz bambriz bambriz approved these changes

@annatisch annatisch annatisch approved these changes

@FabianMeiswinkel FabianMeiswinkel FabianMeiswinkel approved these changes

@kushagraThapar kushagraThapar Awaiting requested review from kushagraThapar kushagraThapar is a code owner

Assignees
No one assigned
Labels
Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@simorenoh @azure-sdk @davidtingsu @bambriz @annatisch @FabianMeiswinkel @xinlian12