[Monitor][Ingestion] Add check for logs input type #32591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvaneck
requested review from
sarangan12,
joshfree,
KarishmaGhiya,
scottaddie,
gracewilcox,
srnagar and
jairmyree
In some cases, a user may pass a dictionary to the upload method where a list is expected. Since, a dictionary is still iterable, the keys of the dictionary will be looped through, gzipped, and sent to the service. The user will still get a 204 response, but the data won't show in the workspace because the data was mangled in the gzipping process. This adds a check to the upload method that will let users know if their input isn't the correct type. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
ingestion-tsg-update
branch
from
3722b4b
to
4fc8f06
Compare
|
API change check API changes are not detected in this pull request. |
xiangyan99
reviewed
Oct 20, 2023
sdk/monitor/azure-monitor-ingestion/azure/monitor/ingestion/aio/_operations/_patch.py
Show resolved
Hide resolved
xiangyan99
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, a user may pass a dictionary to the upload method where a list is expected. Since, a dictionary is still iterable, the keys of the dictionary will be looped through, gzipped, and sent to the service. The user will still get a 204 response, but the data won't show in the workspace because the data was mangled in the gzipping process.
This adds a check to the upload method that will let users know if their input isn't the correct type.
Closes: #32562