-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Index metrics to python sdk #33034
Conversation
This PR adds Index Metrics to Python SDK
API change check APIView has identified API level changes in this PR and created following API reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small suggestions but great stuff nonetheless, thank you Bryan! 👍
let's make sure to include the CHANGELOG like you said as well
sdk/cosmos/azure-cosmos/azure/cosmos/_cosmos_client_connection.py
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/azure/cosmos/aio/_cosmos_client_connection_async.py
Outdated
Show resolved
Hide resolved
also side random question, but from what I saw we send "x-ms-cosmos-populateindexmetrics" and the service returns "x-ms-cosmos-index-utilization" - is that right? there's no other additional headers that get returned on this right? |
That is correct. |
/azp run python - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
Removed the param reference so that we can use it as a keyword
/azp run python - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks Bryan!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @bambriz !
Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>
This PR adds Index Metrics to Python SDK.
You can capture index metrics by passing in the populate_index_metrics keyword in query items.
query_items = container.query_items(query="Select * from c", populate_index_metrics=True)
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines