New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Add anyio dependency for lock handling #33307
Conversation
6400320
to
c2b637c
Compare
API change check API changes are not detected in this pull request. |
- This introduces anyio as a dependency to azure-core and we leverage its `Lock` class in `AsyncBearerTokenCredentialPolicy` to allow it to work with both asyncio and trio concurrency mechanisms. - Requests was also bumped to allow the mindependency check to pass with the minimum version of `anyio`. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
/check-enforcer override |
😩 This forces installation of multiple additional transitive dependencies for any and all users of
It might be better to explore whether the same thing could be done without forcing the dependency; after all, there are plenty of other places in |
Thanks for your feedback. In terms of "there are plenty of other places in azure-core that only support asyncio still." if you don't mind, could you share more details? |
anyio
as a dependency toazure-core
, and we leverage itsLock
class inAsyncBearerTokenCredentialPolicy
to allow it to work with both asyncio and trio concurrency mechanisms.requests
was also bumped to allow themindependency
check to pass with the minimum version ofanyio
.Closes: #32968