[Key Vault] Remove direct uses of asyncio.sleep
#33819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccoyp
added
KeyVault
Client
|
/azp run python - keyvault - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API change check API changes are not detected in this pull request. |
mccoyp
force-pushed
the
kv-asyncio
branch
2 times, most recently
from
6076733
to
f97ef3a
Compare
|
/azp run python - keyvault - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - keyvault - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kristapratico
approved these changes
Jan 22, 2024
sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/aio/_client.py
Show resolved
Hide resolved
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-python
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #33748. Key Vault uses a handful of custom polling methods, which currently use
asyncio.sleepdirectly. This PR refactors them to instead use the client transport's ownsleepmethod. Polling methods now accept an operation's original pipeline response as a parameter and use its pipeline context.asynciois still imported and used directly in tests and samples; a separate PR will follow this one to remove test instances (to keep this PR as simple as possible).All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines