[ServiceBus] update amqpLink/Session/Connection network trace to comply with otel spec #34237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
kashifkhan
reviewed
Feb 8, 2024
|
|
||
| def format(self, record: logging.LogRecord) -> str: | ||
| if not "amqpConnection" in record.__dict__: | ||
| record.__dict__["amqpConnection"] = None |
There was a problem hiding this comment.
if the values are not supposed to be None, why are they being set so here?
There was a problem hiding this comment.
they aren't supposed to be None for Otel, but if we're just printing them out/logging to other places, this should be fine. However, you're right in that I'm not sure how exactly this will affect otel, since the same extra params won't be present everywhere.
kashifkhan
reviewed
Feb 8, 2024
| @@ -135,7 +135,7 @@ def __init__( # pylint:disable=too-many-locals,too-many-statements | |||
| custom_endpoint = f"{custom_parsed_url.hostname}:{custom_port}{custom_parsed_url.path}" | |||
| self._container_id = container_id or str(uuid.uuid4()) | |||
| self._network_trace = network_trace | |||
| self._network_trace_params = {"amqpConnection": self._container_id, "amqpSession": None, "amqpLink": None} | |||
| self._network_trace_params = {"amqpConnection": self._container_id} | |||
There was a problem hiding this comment.
didn't we add this to fix another bug in our set up ? Would this cause it to resurface those errors?
|
closing in favor of #34365 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #32190
Currently, the network trace values amqpLink/Session/Connection IDs are set to None by default, which results in errors when used with otel. As per the OpenTelemetry spec, attribute values should not be None but CAN BE empty strings. Fixing to comply with the otel spec.
Adding a snippet to the README logging section to be used for formatting/logging this extra network trace info.
TODO: