Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[corehttp] use typeguard for HTTPPolicy/SansIOHTTPPolicy check not isinstance #34296

Merged
merged 14 commits into from
Feb 23, 2024
Merged

[corehttp] use typeguard for HTTPPolicy/SansIOHTTPPolicy check not isinstance #34296

merged 14 commits into from
Feb 23, 2024

Commits on Feb 13, 2024

  1. sansiohttppolicy inherits from protocol

    @swathipil
    swathipil committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    d15be82 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. fix sans io policy tests

    @swathipil
    swathipil committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    1546e57 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. fix mypy errors

    @swathipil
    swathipil committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    d0fc0d0 View commit details
    Browse the repository at this point in the history

  2. fix httpresponse/requesttype is unbound in retry + contravariant sans… 

    …io policy
    @swathipil
    swathipil committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    7298410 View commit details
    Browse the repository at this point in the history

  3. remove extra import

    @swathipil
    swathipil committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    37815c5 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. fix pylint/black

    @swathipil
    swathipil committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    98f0f45 View commit details
    Browse the repository at this point in the history

  2. address paul's comments

    @swathipil
    swathipil committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    022da56 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. update sansiohttppolicy on_response/on_request to return None for mypy

    @swathipil
    swathipil committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    31dc887 View commit details
    Browse the repository at this point in the history

  2. add is_http_policy/is_sansio_policy typeguard check

    @swathipil
    swathipil committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    312d569 View commit details
    Browse the repository at this point in the history

  3. add tests

    @swathipil
    swathipil committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    cefdd4a View commit details
    Browse the repository at this point in the history

  4. black

    @swathipil
    swathipil committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    1dce1cb View commit details
    Browse the repository at this point in the history

  5. add back elif policy

    @swathipil
    swathipil committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    146d436 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. add typing to is__policy checks + tests

    @swathipil
    swathipil committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    a436dad View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com>
    @swathipil @pvaneck
    swathipil and pvaneck committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    cba79f5 View commit details
    Browse the repository at this point in the history