Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmos] changes and sample for vector search control plane update #34882

Closed
wants to merge 18 commits into from

Conversation

simorenoh
Copy link
Member

@simorenoh simorenoh commented Mar 21, 2024

Changes for control-plane vector search bits, adding the vector embedding policy to container creation flow and the vector indexes to the existing indexing policy based on the doc shared and PRs done by the service team.

Samples and tests have been added as well.

Relevant updates just mean our indexing policy now has additional vector indexing fields:
image

And we now have the ability to pass in a new vector embedding policy json that looks like this:
image

I opted for leaving a raw dictionary/json for the new policy since it aligns with the already existing indexing policy, but if we feel we should change this do let me know.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-cosmos

@simorenoh simorenoh marked this pull request as ready for review March 28, 2024 20:02
Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, however, requesting changes on some documentation

sdk/cosmos/azure-cosmos/README.md Outdated Show resolved Hide resolved
sdk/cosmos/azure-cosmos/azure/cosmos/aio/_database.py Outdated Show resolved Hide resolved
sdk/cosmos/azure-cosmos/README.md Show resolved Hide resolved
@simorenoh
Copy link
Member Author

/azp run python - cosmos

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simorenoh
Copy link
Member Author

/azp run python - cosmos

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simorenoh
Copy link
Member Author

/azp run python - cosmos - ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simorenoh
Copy link
Member Author

These changes were merged as part of #35468.

@simorenoh simorenoh closed this May 17, 2024
@simorenoh simorenoh deleted the vector-search-policy-updates branch May 22, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants